Page MenuHome

Fix T64342: Incorrect snapping of focus object in camera view
ClosedPublic

Authored by Sergey Sharybin (sergey) on Jul 4 2019, 3:23 PM.

Details

Summary

Use more granular dependency graph traversal, which allows to ignore
dependencies which are not related on transform.

Diff Detail

Repository
rB Blender

Event Timeline

Make sure source components are never sent to callback

This revision is now accepted and ready to land.Jul 4 2019, 5:09 PM

Everything seems fine.
I tested dependencies involving modifiers to be sure.
(The result was not quite what I expected but works the same way without the patch).
So okay.

@Germano Cavalcante (mano-wii), can you elaborate on the modifiers?

I had by myself that when a modifier has a dependency with the object being transformed or edited, the object with the modifier should be ignored to snap (as this would avoid some cycle of dependent updates).

I don't know if this has ever worked so, but it is possible to snap to an object (with boolean or sphrink warp) even though there is a dependency on the modifier settings.

@Germano Cavalcante (mano-wii), in the middle of another bugfix currently, but i would expect that this patch should properly detect such cases. At least the depsgraph part of it, the LIB_TAG_DOIT logic might be wrong in transform, but you might have more knowledge about it by now.

What could help is if you prepare simple .blend file, so i can easily have a look and verify this patch after i'm done with my current bugfix.

That "dependency problem" is also seen in 2.79.
It has no relation to this patch and is not very serious.
But I'll make a report showing the case ;)