DrawManager: Wireframe overlay state crash
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jul 10 2019, 1:03 PM.

Details

Reviewers

Clément Foucault (fclem)
Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Maniphest Tasks

T66654: Vertex Paint crash selecting faces with showing wire & multi 3D viewports

Commits

rBbb7b741d2f1c: Fix T66654: wireframe overlay crash in vertex paint in some cases

Summary

mesh_cache state could become corrupted as wire_edge batch was cleared
when selecting in paint modes. When this happened the MBC_WIRE_EDGES was
not reset.

Diff Detail

Repository

rB Blender

Branch

T66654 (branched from master)

Build Status

Buildable 4016
Build 4016: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Jul 10 2019, 1:03 PM

Harbormaster completed remote builds in B4015: Diff 16297.Jul 10 2019, 1:03 PM

Jeroen Bakker (jbakker) added reviewers: Clément Foucault (fclem), Brecht Van Lommel (brecht), Sergey Sharybin (sergey).Jul 10 2019, 1:04 PM

This is the oposite of the fix. You need to remove the MBC_WIRE_EDGES. We clear this batch because it uses the VBO loop_pos_nor.

This revision now requires changes to proceed.Jul 10 2019, 1:17 PM

@Clément Foucault (fclem) just came to the same conclusion. Should be fixed now

Harbormaster completed remote builds in B4016: Diff 16298.Jul 10 2019, 1:22 PM

Clément Foucault (fclem) accepted this revision.Jul 10 2019, 1:24 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 10 2019, 5:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 10 2019, 5:07 PM

Closed by commit rBbb7b741d2f1c: Fix T66654: wireframe overlay crash in vertex paint in some cases (authored by Jeroen Bakker (jbakker), committed by Brecht Van Lommel (brecht)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBbb7b741d2f1c: Fix T66654: wireframe overlay crash in vertex paint in some cases.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_impl_mesh.c

2 lines

Diff 16298

View Options

source/blender/draw/intern/draw_cache_impl_mesh.c

DrawManager: Wireframe overlay state crashClosedPublicActions