Move sequence, movieclip and text editor progressbars to status bar
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Jul 10 2019, 5:17 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Commits

rB2c4dfbb00246: Fix T66028: Move sequence, movieclip and text editor progressbars to status bar

Summary

fix T66028: Proxy in VSE does not work

Tested only VSE portion now

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) created this revision.Jul 10 2019, 5:17 PM

- fix asignment of owner

Harbormaster completed remote builds in B4188: Diff 16643.Jul 29 2019, 12:56 AM

Richard Antalik (ISS) retitled this revision from Fix some progressbars are not shown to Move sequence, movieclip and text editor progressbars to status bar.Jul 29 2019, 1:00 AM

Richard Antalik (ISS) edited the summary of this revision. (Show Details)

William Reynish (billreynish) awarded a token.Jul 29 2019, 10:05 AM

Can confirm it is working(on Win 10) for the Sequencer and the Movie Clip Editor.

It seems that for movie clip this change doesn't move progress, but also shows it in the status bar, making it so progress is displayed in both clip editor's header and status bar. I don't think this is a great redundancy.

Also think if the progress is to be always displayed in the status bar, do we still need an owner parameter to WM_jobs_get() ?

There are unused variables warnings induced by this change:
tracking_ops_solve.c:194:12: warning: unused variable ‘sa’ [-Wunused-variable]
tracking_ops_track.c:291:12: warning: unused variable ‘sa’ [-Wunused-variable]

This revision now requires changes to proceed.Jul 29 2019, 12:47 PM

fix unused vars
remove jobs template from clip editor

Harbormaster completed remote builds in B4198: Diff 16662.Jul 29 2019, 10:35 PM

In D5219#121056, @Sergey Sharybin (sergey) wrote:

Also think if the progress is to be always displayed in the status bar, do we still need an owner parameter to WM_jobs_get() ?

Technically no, but some editors may rely on owner when they build up queue(context may be part of jobs customdata, not queue element itself)?
I can go through all callees to check, there are not so many.

Looks good, even if potentially code can be simplified further with removal of owner.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 10:37 PM

Closed by commit rB2c4dfbb00246: Fix T66028: Move sequence, movieclip and text editor progressbars to status bar (authored by Richard Antalik (ISS)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB2c4dfbb00246: Fix T66028: Move sequence, movieclip and text editor progressbars to status bar.