Fix T66587: Can't bake second dynamic paint canvas to image sequence
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Jul 10 2019, 5:55 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Commits

rB8fa50b522a10: Fix T66587: Can't bake second dynamic paint canvas to image sequence

Summary

The issue was the the copy data function didn't copy the active canvas number.
So it would always be 0 and thus use the first canvas when trying to bake.

Also fix not copying unused type data (unused canvas/brush settings).

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) created this revision.Jul 10 2019, 5:55 PM

Sebastian Parborg (zeddb) mentioned this in T66587: Can't bake second dynamic paint canvas to image sequence.

LGTM.

Probably commit after RC1 is officially out? @Brecht Van Lommel (brecht) how do you think we should approach fixes like this from now?

This revision is now accepted and ready to land.Jul 10 2019, 6:55 PM

This one should be ok to commit still.

I noticed an other error while working on this. If you copied a dynpaint object, the unused type data would be lost.
Now the unused data is copied even if it won't be used (until the user toggles the type).

Brecht Van Lommel (brecht) accepted this revision.Jul 14 2019, 6:16 PM

Closed by commit rB8fa50b522a10: Fix T66587: Can't bake second dynamic paint canvas to image sequence (authored by Sebastian Parborg (zeddb)). · Explain WhyJul 15 2019, 10:47 AM

This revision was automatically updated to reflect the committed changes.

Sebastian Parborg (zeddb) added a commit: rB8fa50b522a10: Fix T66587: Can't bake second dynamic paint canvas to image sequence.