Page MenuHome
Differential D5226

Fix T66706: crash in viewport shading popover for workbench engine
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jul 11 2019, 2:20 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Jeroen Bakker (jbakker)
Commits
rBf0b72a776ed8: Fix T66706: crash in viewport shading popover for workbench engine
Summary

It's not valid for itemf() to return NULL. Further, when the shading type
is set to lookdev this is handled as solid for workbench, so the color type
should be available.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) created this revision.Jul 11 2019, 2:20 PM
Harbormaster completed remote builds in B4025: Diff 16317.Jul 11 2019, 2:20 PM
Sergey Sharybin (sergey) accepted this revision.Jul 11 2019, 2:59 PM
Sergey Sharybin (sergey) added inline comments.
source/blender/makesrna/intern/rna_space.c
1083–1085

workbench.

This revision is now accepted and ready to land.Jul 11 2019, 2:59 PM
Closed by commit rBf0b72a776ed8: Fix T66706: crash in viewport shading popover for workbench engine (authored by Brecht Van Lommel (brecht)). · Explain WhyJul 11 2019, 3:10 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBf0b72a776ed8: Fix T66706: crash in viewport shading popover for workbench engine.

Revision Contents
Changeset List

PathSize
source/
blender/
makesrna/
intern/
11 lines

Diff 16320

View Options

source/blender/makesrna/intern/rna_space.c

Loading...