Paths

Table of Contentst

Differential D5230

Fix T66604: Cycles bake crash on specific scene with volume
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jul 11 2019, 3:24 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rC17ea9adf5620: Fix T66604: Cycles bake crash on specific scene with volume
rB7ad21c3876c2: Fix T66604: Cycles bake crash on specific scene with volume

Summary

The issue was caused by un-initialized local storage for volume
intersection hits which are supposed to be stored in per-thread
KernelGlobals.

Fix is to make thread_shader() be the same as thread_render() in
respect of KernelGlobals.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) created this revision.Jul 11 2019, 3:24 PM

Harbormaster completed remote builds in B4029: Diff 16323.Jul 11 2019, 3:24 PM

Brecht Van Lommel (brecht) requested changes to this revision.Jul 11 2019, 3:32 PM

Brecht Van Lommel (brecht) added inline comments.

intern/cycles/device/device_cpu.cpp
1002–1003	Missing `delete kg;`?

This revision now requires changes to proceed.Jul 11 2019, 3:32 PM

Added missing delete.

Harbormaster completed remote builds in B4030: Diff 16324.Jul 11 2019, 3:38 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 11 2019, 3:42 PM

This revision is now accepted and ready to land.Jul 11 2019, 3:42 PM

Closed by commit rB7ad21c3876c2: Fix T66604: Cycles bake crash on specific scene with volume (authored by Sergey Sharybin (sergey)). · Explain WhyJul 11 2019, 3:44 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB7ad21c3876c2: Fix T66604: Cycles bake crash on specific scene with volume.

Brecht Van Lommel (brecht) added a commit: rC17ea9adf5620: Fix T66604: Cycles bake crash on specific scene with volume.Aug 22 2019, 5:19 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

device/

12 lines

Diff 16325

intern/cycles/device/device_cpu.cpp

Loading...