Fix T66668: frame selected bone not working in weight paint mode
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jul 12 2019, 9:59 AM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)

Maniphest Tasks

T66668: Blender not focusing on bone with period key in weight paint mode

Commits

rB70d193203bba: Fix T66668: frame selected bone not working in weight paint mode

Summary

'viewselected_exec()' [which uses evaluated view layer] would query BASE_SELECTED flag, but it was not set on base_eval, but on its base_orig.

reason for this is 'ed_object_select_pick()' [or even more generally 'view3d_select_exec()'] would modify base flags [through 'ED_object_base_select()' etc], but not tag scene ID_RECALC_BASE_FLAGS.

thx @Sergey Sharybin (sergey) for hinting.

(still I am unsure how costly recalculating base flags really is, so I proposed 3 possible places for the tagging...)

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jul 12 2019, 9:59 AM

Harbormaster completed remote builds in B4034: Diff 16333.Jul 12 2019, 9:59 AM

Philipp Oeser (lichtwerk) added inline comments.Jul 12 2019, 10:02 AM

source/blender/editors/space_view3d/view3d_edit.c
2953 ↗	(On Diff #16333)	why is this so? ... still figuring this out actually... note there is also T66742 which I am looking into, so issue might actually be deeper than this...

Philipp Oeser (lichtwerk) marked an inline comment as not done.Jul 12 2019, 10:02 AM

Sergey Sharybin (sergey) added inline comments.Jul 12 2019, 11:11 AM

source/blender/editors/space_view3d/view3d_edit.c
2953 ↗	(On Diff #16333)	This sounds like someone who modified base flags did not tag `DEG_id_tag_update(&scene->id, ID_RECALC_BASE_FLAGS);`

This comment has been deleted.

source/blender/editors/space_view3d/view3d_edit.c
2953 ↗	(On Diff #16333)	Yep, can confirm that `ed_object_select_pick` does a whole lot of `ED_object_base_select` etc. without tagging scene `ID_RECALC_BASE_FLAGS`, can also confirm that tagging scene there fixes the issue. Will update Diff accordingly (just figuring out the best place for the tag...might actually do this in `view3d_select_exec`...) Sidequestion: going over code there it seems often times `DEG_id_tag_update(&scene->id, ID_RECALC_SELECT);` is called numerous times (if you include some "sub-functions" that are called and also tag....). Might be possible to remove some redundancy, but... this doesnt really do harm, right?

will rather tag scene ID_RECALC_BASE_FLAGS in ed_object_select_pick / view3d_select_exec...

Sergey Sharybin (sergey) added inline comments.Jul 12 2019, 2:24 PM

source/blender/editors/space_view3d/view3d_edit.c
2953 ↗	(On Diff #16333)	Tagging is supposed to be cheap, so multiple calls to `DEG_id_tag_update()` should not be a problem. If it ever pops up in a profiles we should solve this from `DEG_id_tag_update()` side.