Fix T64312: Selection inconsistencies when switching collections
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Jul 12 2019, 5:53 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Commits

rBbfa6cb3a7d9a: Fix T64312: Selection inconsistencies when switching collections

Summary

Basically layer_collection_sync was calling BKE_base_eval_flags right away while
iterating over the bases.

However when a parent/sibling collection is to influence the collection flag of
an object that exists in more than one collection, it is too late since we
deselect the object in BKE_base_eval_flags right away.

Related to T64312.

Diff Detail

Repository: rB Blender

Event Timeline

Dalai Felinto (dfelinto) created this revision.Jul 12 2019, 5:53 PM

Harbormaster completed remote builds in B4043: Diff 16349.Jul 12 2019, 5:53 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 17 2019, 7:55 PM

This revision is now accepted and ready to land.Jul 17 2019, 7:55 PM

@Dalai Felinto (dfelinto), as mentioned in IRC, can't spot issues from depsgraph point of view.

Closed by commit rBbfa6cb3a7d9a: Fix T64312: Selection inconsistencies when switching collections (authored by Dalai Felinto (dfelinto)). · Explain WhyJul 18 2019, 12:42 AM

This revision was automatically updated to reflect the committed changes.

Dalai Felinto (dfelinto) added a commit: rBbfa6cb3a7d9a: Fix T64312: Selection inconsistencies when switching collections.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

layer.c

7 lines

Diff 16484

View Options

source/blender/blenkernel/intern/layer.c

Fix T64312: Selection inconsistencies when switching collectionsClosedPublicActions