⚙ D5262 Collada exporter only supports export of Lambert Shaders. But Shininess is not supported with Lambert

Gaia Clary (gaiaclary) created this revision.Jul 15 2019, 5:14 PM

Harbormaster completed remote builds in B4070: Diff 16406.Jul 15 2019, 5:14 PM

Updating D5262: Collada exporter only supports export of Lambert Shaders. But Shininess is not supported with Lambert

Harbormaster completed remote builds in B4071: Diff 16407.Jul 15 2019, 5:21 PM

Roughness is not the same as shininess. The exact mapping depends on the BSDF and is probably hard to figure out.

But I would expect it to be closer to roughness = 1 - shininess. That is the lower the roughness, the shinier the material is.

Collada exporter only supports export of Lambert Shaders.
But Shininess is not supported with Lambert

Collada Importer adds illegal values of -1
for roughness and reflectivity when these
parameters are not defined in the imported collada data

Harbormaster completed remote builds in B4072: Diff 16413.Jul 15 2019, 6:27 PM

Brecht Van Lommel (brecht) requested changes to this revision.Jul 15 2019, 6:50 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/collada/Materials.cpp
134–138	Metallic and Roughness are values in the 0..1 range. Assigning them only if the value is negative makes no sense to me?

This revision now requires changes to proceed.Jul 15 2019, 6:50 PM

Gaia Clary (gaiaclary) mentioned this in T66899: Exporting to Collada sets material roughness to 0.Jul 15 2019, 6:56 PM

argh, i meant >=0

Collada exporter only supports export of Lambert Shaders. But Shininess is not supported with Lambert

Collada Importer adds illegal values of -1
for roughness and reflectivity when these
parameters are not defined in the imported collada data

Harbormaster completed remote builds in B4073: Diff 16414.Jul 15 2019, 7:39 PM

Postponed support for import of shininess to a later release (Blender 2.81)

Harbormaster completed remote builds in B4074: Diff 16415.Jul 15 2019, 8:33 PM

Looks ok to commit now.

This revision is now accepted and ready to land.Jul 16 2019, 12:05 PM

Closed by commit rBdd3e3474abcb: fix T66899: Collada: Shininess/Reflectivity not handled correct (authored by Gaia Clary (gaiaclary)). · Explain WhyJul 16 2019, 1:28 PM

This revision was automatically updated to reflect the committed changes.

Gaia Clary (gaiaclary) added a commit: rBdd3e3474abcb: fix T66899: Collada: Shininess/Reflectivity not handled correct.

@Gaia Clary (gaiaclary) I just now noticed, this feature was removed.
I was actually using it in my projects (with my own hacky importer...).
Any chance on getting shininess and specular export (or some equivalent) back anytime soon?
Currently I don't know how to workaround this other than reverting this commit manually on a local build.

Collada exporter only supports export of Lambert Shaders. But Shininess is not supported with Lambert
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 16431

source/blender/collada/DocumentImporter.cpp

source/blender/collada/EffectExporter.cpp

source/blender/collada/Materials.cpp

Collada exporter only supports export of Lambert Shaders. But Shininess is not supported with LambertClosedPublicActions