Restore grid spacing info in 3D views (as present in 2.79)
AbandonedPublic
Actions

Authored by Forest Katsch (zlsa) on Jul 16 2019, 8:39 AM.

Details

Reviewers

Clément Foucault (fclem)
Germano Cavalcante (mano-wii)
Jeroen Bakker (jbakker)

Maniphest Tasks

T61286: Viewport grid units should be visible

Summary

This patch restores prior functionality from 2.79 and before by displaying the current grid spacing in the 3D view.

Example:

Also added was a new flag in the eUserpref_UI_Flag enum: USER_SHOW_GRIDSPACING, and a corresponding checkbox in the user preferences. I'm not sure if this is the right (or the best) way to do this, so feedback is welcome.

If I understand versioning_userdef.inc correctly, then this option is disabled by default when loading files from before 2.80 (which I believe is the more sane option.)

This legend only shows up when all of the following conditions are met:

The "Grid Spacing" checkbox in the User Preferences (Viewport > Display) is checked.
The 3D view is in orthographic mode.
The 3D view is facing one of the preset cardinal axes.
The unit system is either Metric or Imperial.

If any of the conditions are not met, the legend is not drawn.

This patch resolves T61286.

Diff Detail

Repository: rB Blender

Event Timeline

Forest Katsch (zlsa) created this revision.Jul 16 2019, 8:39 AM

Forest Katsch (zlsa) edited the summary of this revision. (Show Details)

Forest Katsch (zlsa) edited the summary of this revision. (Show Details)Jul 16 2019, 8:42 AM

Duarte Farrajota Ramos (duarteframos) awarded a token.Jul 16 2019, 12:19 PM

Duarte Farrajota Ramos (duarteframos) rescinded a token.

Duarte Farrajota Ramos (duarteframos) added a subscriber: Duarte Farrajota Ramos (duarteframos).

Brecht Van Lommel (brecht) edited reviewers, added: Clément Foucault (fclem), Germano Cavalcante (mano-wii), Jeroen Bakker (jbakker); removed: User Interface.Jul 16 2019, 7:20 PM

Use the existing function in draw_manager to draw text in 3D view.
We already have a patch that proposes to fix the same problem (D4325).
And the problem presented in patch D4379 needs to be resolved first.

I didn't even see that after searching for it! I'll close this in favor of yours, which seems to handle unit scale properly.

(Side note: I was under the impression ED_view3d_grid_view_scale would return the unit-scale-normalized grid spacing, but it appears that it does not.)