Page MenuHome
Differential D5269

X3D: Fix T67053: export with "Selection Only" error
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jul 16 2019, 3:42 PM.

Details

Reviewers
Bastien Montagne (mont29)
Brecht Van Lommel (brecht)
Maniphest Tasks
T67053: Export_X3d (ERROR)
Commits
rBA37fe422f9a19: X3D: Fix T67053: export with "Selection Only" error

Diff Detail

Repository
rBA Blender Add-ons
Branch
T67053 (branched from master)
Build Status
Buildable 4084
Build 4084: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jul 16 2019, 3:42 PM
Harbormaster completed remote builds in B4083: Diff 16437.Jul 16 2019, 3:42 PM
Brecht Van Lommel (brecht) requested changes to this revision.EditedJul 16 2019, 3:45 PM

It should iterate over view_layer.objects instead of scene.objects for both the selection and non-selection case. Only then does it make sense to query if the object is visible or selected in the view layer.

This revision now requires changes to proceed.Jul 16 2019, 3:45 PM
Philipp Oeser (lichtwerk) updated this revision to Diff 16438.Jul 16 2019, 4:00 PM

only iterate viewlayer objects [only exporting objects visible there anyways...]

Harbormaster completed remote builds in B4084: Diff 16438.Jul 16 2019, 4:00 PM
Brecht Van Lommel (brecht) accepted this revision.Jul 16 2019, 4:15 PM
This revision is now accepted and ready to land.Jul 16 2019, 4:15 PM
Closed by commit rBA37fe422f9a19: X3D: Fix T67053: export with "Selection Only" error (authored by Philipp Oeser (lichtwerk)). · Explain WhyJul 17 2019, 10:16 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBA37fe422f9a19: X3D: Fix T67053: export with "Selection Only" error.

Revision Contents
Changeset List

PathSize
io_scene_x3d/
5 lines

Diff 16438

View Options

io_scene_x3d/export_x3d.py

Loading...