Page MenuHome
Differential D5274

Fix T67078: Crash with vertex slide and multi-objects
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Jul 17 2019, 3:57 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T67078: Blender crashes while trying to slide verticies (double G function)Project file included.
Commits
rBd90201aee219: Edge Slide: Fix multi-object for loop early exit
rB5ca302cb0cb4: Fix T67078: Crash with vertex slide and multi-objects
Summary

Main commit:

If one of the objects had invalid selected edges, it would lead to a
crash since none of the for loops were checking for whether the edge
slide data is valid.

We could refactor the macros to create a new
FOREACH_TRANS_DATA_CONTAINER_WITH_DATA

However we are too close to 2.80 final release so we manually skip them
for now.

Note: TRANS_DATA_CONTAINER_FIRST_OK cannot be used either for the same
reason.

Bonus commit:

Edge Slide: Fix multi-object for loop early exit

Diff Detail

Repository
rB Blender

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
transform/
50 lines
4 lines

Diff 16450

View Options

source/blender/editors/transform/transform.c

Loading...
View Options

source/blender/editors/transform/transform_conversions.c

Loading...