Archimesh: fix usages of bpy.ops.object.select_all
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jul 17 2019, 4:07 PM.

Details

Reviewers

Antonio Vazquez (antoniov)
Bastien Montagne (mont29)
Brecht Van Lommel (brecht)

Maniphest Tasks

T67048: Adding archimesh stairs object to the scene flips normals of all other objects in scene

Commits

rBA184f7341bd17: Archimesh: fix usages of bpy.ops.object.select_all

Summary

Fixes T67048: Adding archimesh stairs object to the scene flips normals
of all other objects in scene

Diff Detail

Repository

rBA Blender Add-ons

Branch

_T67048 (branched from master)

Build Status

Buildable 4099
Build 4099: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jul 17 2019, 4:07 PM

Harbormaster completed remote builds in B4099: Diff 16464.Jul 17 2019, 4:07 PM

@Philipp Oeser (lichtwerk) I think is ok. The code still had the old select method without the name parameter. Sure, I missed during the conversion to 2.80 some months ago.

This revision is now accepted and ready to land.Jul 17 2019, 4:11 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 17 2019, 4:17 PM

Closed by commit rBA184f7341bd17: Archimesh: fix usages of bpy.ops.object.select_all (authored by Philipp Oeser (lichtwerk)). · Explain WhyJul 17 2019, 4:36 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBA184f7341bd17: Archimesh: fix usages of bpy.ops.object.select_all.

Revision Contents
Changeset List

Path

Size

archimesh/

achm_books_maker.py

2 lines

achm_column_maker.py

18 lines

achm_curtain_maker.py

4 lines

achm_kitchen_maker.py

2 lines

achm_lamp_maker.py

2 lines

achm_roof_maker.py

4 lines

achm_shelves_maker.py

2 lines

achm_stairs_maker.py

4 lines

achm_tools.py

4 lines

Diff 16464

View Options

archimesh/achm_books_maker.py

View Options

archimesh/achm_column_maker.py

View Options

archimesh/achm_curtain_maker.py

View Options

archimesh/achm_kitchen_maker.py

View Options

archimesh/achm_lamp_maker.py

View Options

archimesh/achm_roof_maker.py

View Options

archimesh/achm_shelves_maker.py

View Options

archimesh/achm_stairs_maker.py

View Options

Archimesh: fix usages of bpy.ops.object.select_allClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16464

archimesh/achm_books_maker.py

archimesh/achm_column_maker.py

archimesh/achm_curtain_maker.py

archimesh/achm_kitchen_maker.py

archimesh/achm_lamp_maker.py

archimesh/achm_roof_maker.py

archimesh/achm_shelves_maker.py

archimesh/achm_stairs_maker.py

archimesh/achm_tools.py

Archimesh: fix usages of bpy.ops.object.select_all
ClosedPublic
Actions

Revision Contents
Changeset List