Fix Crash: Missing DEG tag update mask layer
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jul 17 2019, 4:07 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Maniphest Tasks

T67127: Adding masks layers crashes blender

Commits

rBf17e2f8dac3a: Fix T67127: Crash Missing DEG tag update mask layer

Summary

When creating a mask layer the original mask was not tagged to be updated resulting in missing data on the copy. The Masking function assumes that the copy and the original is always structured the same.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Jul 17 2019, 4:07 PM

Harbormaster completed remote builds in B4100: Diff 16465.Jul 17 2019, 4:07 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jul 17 2019, 4:09 PM

Jeroen Bakker (jbakker) added reviewers: Brecht Van Lommel (brecht), Sergey Sharybin (sergey).

Also added when removing a mask layer

Harbormaster completed remote builds in B4101: Diff 16467.Jul 17 2019, 4:15 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 17 2019, 4:18 PM

Seems there are more missing DEG updates: P1042

And added for move layers

Harbormaster completed remote builds in B4102: Diff 16468.Jul 17 2019, 4:21 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 17 2019, 4:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 17 2019, 4:26 PM

Closed by commit rBf17e2f8dac3a: Fix T67127: Crash Missing DEG tag update mask layer (authored by Jeroen Bakker (jbakker)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rBf17e2f8dac3a: Fix T67127: Crash Missing DEG tag update mask layer.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

mask/

mask_ops.c

3 lines

Diff 16469

View Options

source/blender/editors/mask/mask_ops.c

Fix Crash: Missing DEG tag update mask layerClosedPublicActions