Fix T67140: Moving a pose bone doesnt update the bone's transform button props realtime.
AbandonedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Jul 17 2019, 10:57 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)

Maniphest Tasks

T67140: bone transform value doesn´t updating

Summary

A solution similar to rBaa7db99a38ec but now for the transform button props of the bone.

Ref T67140

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 4113
Build 4113: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Jul 17 2019, 10:57 PM

Harbormaster completed remote builds in B4113: Diff 16483.Jul 17 2019, 10:57 PM

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Jul 17 2019, 10:57 PM

Germano Cavalcante (mano-wii) added a task: T67140: bone transform value doesn´t updating.

It's slightly more correct to tweak buttons_area_listener to redraw the bone properties on ND_POSE, since ND_BONE_ACTIVE is normally meant for when the active bone changes.

Analyzing the code, ND_POSE only redraws the panels of the Object Data tab.
But I don't see anything on the Object Data tab that needs to be updated when transforming.
Imho, WM_event_add_notifier(C, NC_OBJECT | ND_POSE, NULL) could even be removed and instead use either ND_BONE_ACTIVE or ND_BONE_SELECT.

ND_BONE_ACTIVE and ND_BONE_SELECT are meant for when the active bone or selection of bones changes.

So, better to tweak buttons_area_listener to handle ND_POSE for this case.

This revision now requires changes to proceed.Aug 16 2019, 4:22 PM

Fix committed in rB2f8ea1c11e10: Fix T67140: transforming bone does not update bone tab in properties editor.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

transform/

transform.c

1 line

Diff 16483

View Options

source/blender/editors/transform/transform.c

Fix T67140: Moving a pose bone doesnt update the bone's transform button props realtime.AbandonedPublicActions