Differential D5288

Fix T67062: Movie Clip Editor does not update Editor Type when changing Editing Context
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Jul 18 2019, 3:01 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rB4b2e6d4e22dc: Fix T67062: Movie Clip Editor does not update Editor Type when changing Editing…

Summary

Previously when switching modes, the code didn't check if we were in the correct view for the masking mode.

Is this an acceptable solution or should I add view checks in other places instead?

Diff Detail

Repository: rB Blender

Event Timeline

Sebastian Parborg (zeddb) created this revision.Jul 18 2019, 3:01 PM

Sebastian Parborg (zeddb) mentioned this in T67062: Movie Clip Editor does not update Editor Type when changing Editing Context.

Think this is safest way for now.

Ideally the space clip will ignore the dopesheet/graph view will be ignored in masking mode, but that is more intrusive change which will poke space refres somehow.

This revision is now accepted and ready to land.Jul 18 2019, 3:11 PM

Closed by commit rB4b2e6d4e22dc: Fix T67062: Movie Clip Editor does not update Editor Type when changing Editing… (authored by Sebastian Parborg (zeddb)). · Explain WhyJul 18 2019, 3:28 PM

This revision was automatically updated to reflect the committed changes.

Sebastian Parborg (zeddb) added a commit: rB4b2e6d4e22dc: Fix T67062: Movie Clip Editor does not update Editor Type when changing Editing….

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_clip/

clip_ops.c

5 lines

makesrna/

intern/

rna_space.c

7 lines

Diff 16493

View Options

source/blender/editors/space_clip/clip_ops.c