Fix T65717: Alembic (camera - also mesh) import scale issue
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Jul 18 2019, 3:41 PM.

Details

Reviewers

Commits

rB0dece50667f1: Fix T65717: Alembic (camera - also mesh) import scale issue

Summary

Fix for T65717. The w-component of the translation column of the scaled matrix wasn't set to 1.0, which, apart from being incorrect, caused drawing problems.

Not a critical fix, so won't be part of 2.80.

Diff Detail

Repository: rB Blender

Event Timeline

Sybren A. Stüvel (sybren) created this revision.Jul 18 2019, 3:41 PM

Harbormaster completed remote builds in B4117: Diff 16495.Jul 18 2019, 3:41 PM

Sybren A. Stüvel (sybren) mentioned this in T65717: Alembic (camera - also mesh) import scale issue.Jul 18 2019, 3:42 PM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)

Brecht Van Lommel (brecht) requested changes to this revision.Jul 26 2019, 3:14 PM

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Brecht Van Lommel (brecht) added inline comments.

source/blender/alembic/intern/abc_object.cc
345–346	This is quite odd, making a non-affine transform for this purpose. Just switching the order of operations should achieve the same: float scale_mat[4][4]; scale_m4_fl(scale_mat, scale); mul_m4_m4m4(r_mat, scale_mat, r_mat);