intern/cycles/blender/blender_shader.cpp
1369	@Brecht Van Lommel (brecht) please review this. I was not able to get it to work as expected. After some tries I figured out that reversing the `fac` with `color2` did work. I haven't been able to find out why.

We should extend this with Tone and Saturation.
https://blender.community/c/rightclickselect/VGcbbc/

Jeroen Bakker (jbakker) retitled this revision from LookDev: StudioLight Intensity to LookDev: StudioLight Lightness and Saturation.Jul 25 2019, 4:45 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Added Saturation to EEVEE; The plan is to add it to cycles too

Harbormaster completed remote builds in B4155: Diff 16594.Jul 25 2019, 5:00 PM

Support Saturation slider in Cycles

Intensity is fine with me, but I would not add Tone/Temperature and Saturation here.

Lightness is not the right terminology as far as I know. In Blender we use Strength or Exposure.

Brecht Van Lommel (brecht) added inline comments.Jul 25 2019, 5:10 PM

source/blender/draw/engines/eevee/shaders/default_world_frag.glsl
55–58	I don't think the performance impact from this conversion back and forth is acceptable, I would not do saturation controls at all. Only if it can be done with the performance impact, and even then I think saturation as a default control for HDR backgrounds is questionable.

Just saying that I agree with everything @Brecht Van Lommel (brecht) said.

Jeroen Bakker (jbakker) retitled this revision from LookDev: StudioLight Lightness and Saturation to LookDev: StudioLight Intensity.Jul 26 2019, 8:09 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Reverted lightness and saturation.
Renamed intensity to Strength (in UI)

Harbormaster completed remote builds in B4166: Diff 16607.Jul 26 2019, 8:14 AM

Jeroen Bakker (jbakker) marked an inline comment as done.Jul 26 2019, 8:18 AM

Codestyle

Harbormaster completed remote builds in B4167: Diff 16608.Jul 26 2019, 8:19 AM

This patch contains a bunch of Cycles Lookdev changes, difficult to see what's supposed to be reviewed now.

This revision now requires changes to proceed.Jul 31 2019, 12:51 PM

Cycles/EEVEE: Viewport HDRI Intensity Slider

updated with D5612: Shading Modes: Material and Render Preview. Note that that one first needs to be reviewed and committed.

Harbormaster completed remote builds in B4755: Diff 17808.Sep 4 2019, 3:54 PM

Cycles/EEVEE: Viewport HDRI Intensity Slider

Harbormaster completed remote builds in B4756: Diff 17810.Sep 4 2019, 4:01 PM

Cycles/EEVEE: Viewport HDRI Intensity Slider

Harbormaster completed remote builds in B4757: Diff 17811.Sep 4 2019, 4:02 PM

Arc seems to be broken with my workflow...
Might need to open a new one. It doesn't seems to rebase with master

Harbormaster completed remote builds in B4758: Diff 17812.Sep 4 2019, 4:06 PM

Manual changed to diff to work with master.

Still needs work to apply to master....

Brecht Van Lommel (brecht) added inline comments.Sep 4 2019, 4:18 PM

intern/cycles/blender/blender_shader.cpp
1372	`background->strength = new_viewport_parameters.studiolight_intensity;` should work, no need to add a node then.

Brecht Van Lommel (brecht) added inline comments.Sep 4 2019, 4:22 PM

intern/cycles/blender/blender_shader.cpp
1372	Or maybe it's not that simple due to interaction with other settings? In any case, if you use the mix node, then indeed it is correct to use `color2` since `fac` is the mixing factor, it's the two colors that are multiplied together.

Due to internal war in phabricator I uploaded the patch from scratch D5674: Viewport Shading: StudioLight Intensity

Viewport Shading: StudioLight Intensity
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 17811

intern/cycles/blender/CMakeLists.txt

intern/cycles/blender/addon/ui.py

intern/cycles/blender/blender_object.cpp

intern/cycles/blender/blender_session.cpp

intern/cycles/blender/blender_shader.cpp

intern/cycles/blender/blender_sync.h

intern/cycles/blender/blender_sync.cpp

intern/cycles/blender/blender_viewport.h

intern/cycles/blender/blender_viewport.cpp

release/scripts/startup/bl_ui/properties_material.py

release/scripts/startup/bl_ui/space_view3d.py

source/blender/blenkernel/BKE_blender_version.h

source/blender/blenkernel/intern/screen.c

source/blender/blenloader/intern/versioning_280.c

source/blender/draw/engines/eevee/eevee_lookdev.c

source/blender/draw/engines/eevee/eevee_private.h

source/blender/draw/engines/eevee/shaders/default_world_frag.glsl

source/blender/editors/space_view3d/view3d_draw.c

source/blender/makesdna/DNA_view3d_types.h

source/blender/makesrna/intern/rna_space.c

source/blender/windowmanager/intern/wm_init_exit.c

Viewport Shading: StudioLight IntensityAbandonedPublicActions