Page MenuHome
Differential D5306

Remove Annotations panel from non-preview Sequencer areas and Grease Pencil code in space_sequencer.py
ClosedPublic
Actions

Authored by Peter Fog (tintwotin) on Jul 20 2019, 5:30 PM.

Details

Reviewers
William Reynish (billreynish)
Commits
rB1178046ed222: GPencil: Remove Annotations panel from non-preview Sequencer areas
Summary

The Annotations panel does not work in the Sequencer(strip area) or in Backdrop preview mode, and is not supposed to, so it only should be exposed in the Sequencer Preview and Sequencer/Preview modes(T66112). Also, old deprecated Grease Pencil code also needs to be renamed and/or removed from the space_sequencer.py (T67331)

So, this patch fixes these elements:

  • Limit exposing the Annotation panel to view modes: Sequencer Preview and Sequencer/Preview, since the Annotations do not work in the other view modes.
  • Removing SEQUENCER_PT_grease_pencil_tools, since it is old deprecated code, and the panel was not exposed in the UI.
  • Renaming SEQUENCER_PT_grease_pencil to SEQUENCER_PT_annotation, since this is the 2.80 naming.

NB. the Annotations panel in the Sequencer(strip area) is not included in the 2.80 manual, and this fix will not cause an update of the manual.

Diff Detail

Repository
rB Blender

Event Timeline

Peter Fog (tintwotin) created this revision.Jul 20 2019, 5:30 PM
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Jul 20 2019, 5:34 PM
Antonio Vazquez (antoniov) added a reviewer: William Reynish (billreynish).Jul 20 2019, 8:53 PM

@William Reynish (billreynish) Could you review this patch and be sure is correct for the UI?

Peter Fog (tintwotin) updated this revision to Diff 16534.Jul 20 2019, 11:49 PM

Change from GP to Annotation in the comment.

William Reynish (billreynish) awarded a token.Jul 22 2019, 5:19 PM
William Reynish (billreynish) accepted this revision.Jul 22 2019, 5:24 PM

Seems correct to me.

Once the toolbar is added here, it will be consistent with the 3D view.

This revision is now accepted and ready to land.Jul 22 2019, 5:24 PM
Closed by commit rB1178046ed222: GPencil: Remove Annotations panel from non-preview Sequencer areas (authored by Antonio Vazquez (antoniov)). · Explain WhyJul 29 2019, 10:43 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rB1178046ed222: GPencil: Remove Annotations panel from non-preview Sequencer areas.
Peter Fog (tintwotin) mentioned this in T66112: Sequencer Annotation Tool(in the Sequencer Timeline Sidebar) does not draw and has not D-key assigned..Aug 2 2019, 10:36 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
9 lines

Diff 16663

View Options

release/scripts/startup/bl_ui/space_sequencer.py

Loading...