Differential D5309

GPencil: Proposed fix for T67338 - Material options can be changed in panel when material is locked
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Jul 20 2019, 9:28 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB3ee246f614ca: Fix T67338 : GPencil Disable material properties when material is locked

Summary

This disable the options instead of only deactivated.

Diff Detail

Repository: rB Blender

Event Timeline

Antonio Vazquez (antoniov) created this revision.Jul 20 2019, 9:28 PM

Antonio Vazquez (antoniov) mentioned this in T67338: GPencil: locking material leaves some attributes editable.

Disable the header too.

I don't really understand the purpose of this locking. We have locking for transform channels, but that only applies to the 3D viewport for animators to easily animate just the expected channels. But I guess it's consistent with the intended design, whatever the reason was behind it.

This revision is now accepted and ready to land.Jul 26 2019, 3:19 PM

@Brecht Van Lommel (brecht) The problem is when you lock the material in the material list, the panel is disabled and all controls are dimmed, but you can still change the values, so you could change one color by error.