Differential D5349

GPencil: Get current frame from scene
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jul 26 2019, 2:15 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB9270c15af8fc: GPencil: Get current frame from scene

Summary

This change makes it so current frame is queried from a scene rather
than from a dependency graph. This makes it possible to avoid the
fact that dependency graph might not be fully evaluated yet.

There are still some cases where it frame is queried from the graph,
but those seems to be in a code path where we need to ensure valid
dependency graph anyway.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) created this revision.Jul 26 2019, 2:15 PM

Harbormaster completed remote builds in B4172: Diff 16616.Jul 26 2019, 2:15 PM

Sergey Sharybin (sergey) added a child revision: D5343: Fix T67454: Blender crash on rapid undo and select.Jul 26 2019, 2:19 PM

Right, operators like these should be looking at original data, not the depsgraph.

This revision is now accepted and ready to land.Jul 26 2019, 3:02 PM

Closed by commit rB9270c15af8fc: GPencil: Get current frame from scene (authored by Sergey Sharybin (sergey)). · Explain WhyJul 26 2019, 3:21 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB9270c15af8fc: GPencil: Get current frame from scene.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

gpencil/

gpencil_add_monkey.c

4 lines

gpencil_add_stroke.c

4 lines

gpencil_brush.c

9 lines

gpencil_convert.c

12 lines

4 lines

20 lines

gpencil_interpolate.c

8 lines

gpencil_merge.c

4 lines

gpencil_paint.c

2 lines

gpencil_primitive.c

7 lines

gpencil_select.c

4 lines

Diff 16620

source/blender/editors/gpencil/gpencil_add_monkey.c

Loading...

source/blender/editors/gpencil/gpencil_add_stroke.c

Loading...

source/blender/editors/gpencil/gpencil_brush.c

Loading...

source/blender/editors/gpencil/gpencil_convert.c

Loading...

source/blender/editors/gpencil/gpencil_data.c

Loading...

source/blender/editors/gpencil/gpencil_edit.c

Loading...

source/blender/editors/gpencil/gpencil_interpolate.c

Loading...

source/blender/editors/gpencil/gpencil_merge.c

Loading...

source/blender/editors/gpencil/gpencil_paint.c

Loading...

source/blender/editors/gpencil/gpencil_primitive.c

Loading...

source/blender/editors/gpencil/gpencil_select.c

Loading...