Paths

Table of Contentst

Fix T67620: Font preview translations malfunction in Blender 2.8
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Jul 26 2019, 6:04 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Maniphest Tasks

T67620: Font preview malfuction in Blender 2.8

Commits

rB3b6c75dc3182: Fix T67620: Font preview translations malfunction in Blender 2.8

Summary

We cannot reliably use translations API from non-main threads.

Now storing translated strings in a static cache, with basic mechanism
to update it on language change.

Diff Detail

Repository: rB Blender

Event Timeline

Bastien Montagne (mont29) created this revision.Jul 26 2019, 6:04 PM

Harbormaster completed remote builds in B4178: Diff 16627.Jul 26 2019, 6:04 PM

Bastien Montagne (mont29) added a task: T67620: Font preview malfuction in Blender 2.8.Jul 26 2019, 6:04 PM

Seems fine, minor issue noted inline.

source/blender/imbuf/intern/thumbs_font.c
40	Don't think define is needed here, use `static const char *i18n_thumb_str[ARRAY_SIZE(thumb_str)] = {NULL};` instead.

This revision is now accepted and ready to land.Jul 29 2019, 6:02 AM

Closed by commit rB3b6c75dc3182: Fix T67620: Font preview translations malfunction in Blender 2.8 (authored by Bastien Montagne (mont29)). · Explain WhyJul 29 2019, 2:19 PM

This revision was automatically updated to reflect the committed changes.

Bastien Montagne (mont29) marked an inline comment as done.

Bastien Montagne (mont29) added a commit: rB3b6c75dc3182: Fix T67620: Font preview translations malfunction in Blender 2.8.

Committed with suggested change, thx.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenfont/

BLF_api.h

1 line

intern/

blf_thumbs.c

3 lines

blentranslation/

CMakeLists.txt

1 line

intern/

blt_lang.c

3 lines

editors/

space_file/

filelist.c

3 lines

imbuf/

IMB_thumbs.h

17 lines

intern/

thumbs_font.c

36 lines

windowmanager/

intern/

wm_init_exit.c

5 lines

Diff 16650

View Options

source/blender/blenfont/BLF_api.h

View Options

source/blender/blenfont/intern/blf_thumbs.c

View Options

source/blender/blentranslation/CMakeLists.txt

View Options

source/blender/blentranslation/intern/blt_lang.c

View Options

source/blender/editors/space_file/filelist.c

View Options

source/blender/imbuf/IMB_thumbs.h

View Options

source/blender/imbuf/intern/thumbs_font.c

View Options

source/blender/windowmanager/intern/wm_init_exit.c

Fix T67620: Font preview translations malfunction in Blender 2.8ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16650

source/blender/blenfont/BLF_api.h

source/blender/blenfont/intern/blf_thumbs.c

source/blender/blentranslation/CMakeLists.txt

source/blender/blentranslation/intern/blt_lang.c

source/blender/editors/space_file/filelist.c

source/blender/imbuf/IMB_thumbs.h

source/blender/imbuf/intern/thumbs_font.c

source/blender/windowmanager/intern/wm_init_exit.c

Fix T67620: Font preview translations malfunction in Blender 2.8
ClosedPublic
Actions

Revision Contents
Changeset List