Page MenuHome
Differential D5361

Fix T67460: Vertex painting: Sampling color opens empty options window in viewport
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Jul 29 2019, 12:11 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Commits
rB77cc69d66ff0: Fix T67460: Vertex painting: Sampling color opens empty options window in…
Summary

The issue was that the redo panel area would call with region type HUD (not WINDOW).
Now we make sure that the redo panel always polls the operator in the original area type context.

Diff Detail

Repository
rB Blender

Event Timeline

Sebastian Parborg (zeddb) created this revision.Jul 29 2019, 12:11 PM
Sebastian Parborg (zeddb) mentioned this in T67460: Vertex painting: Sampling color opens empty options window in viewport.
Brecht Van Lommel (brecht) requested changes to this revision.Jul 30 2019, 12:32 AM

The redo panel should call poll functions with the region that the operator was executed in. If we have to work around it here, there's probably other operators that have the same problem.

This revision now requires changes to proceed.Jul 30 2019, 12:32 AM
Sebastian Parborg (zeddb) updated this revision to Diff 16683.Jul 30 2019, 12:22 PM
Sebastian Parborg (zeddb) edited the summary of this revision. (Show Details)

I've updated the code with your input.

Brecht Van Lommel (brecht) accepted this revision.Jul 30 2019, 12:38 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/interface/interface_region_hud.c
80

End comment with dot

This revision is now accepted and ready to land.Jul 30 2019, 12:38 PM
Sebastian Parborg (zeddb) added a comment.Jul 30 2019, 12:52 PM

This patch actually makes blender crash when the redo panel is invoked in the scripting workspace (when doing certain operations in the 3D view port).
So I'll put off merging this till I can find the cause.

Brecht Van Lommel (brecht) requested changes to this revision.Jul 30 2019, 12:53 PM
This revision now requires changes to proceed.Jul 30 2019, 12:53 PM
Sebastian Parborg (zeddb) updated this revision to Diff 16685.Jul 30 2019, 2:43 PM

This should do it. It doesn't seem to crash any more on my end and the panels are displayed correctly.

Brecht Van Lommel (brecht) accepted this revision.Jul 30 2019, 3:07 PM
This revision is now accepted and ready to land.Jul 30 2019, 3:07 PM
Closed by commit rB77cc69d66ff0: Fix T67460: Vertex painting: Sampling color opens empty options window in… (authored by Sebastian Parborg (zeddb)). · Explain WhyJul 30 2019, 4:01 PM
This revision was automatically updated to reflect the committed changes.
Sebastian Parborg (zeddb) added a commit: rB77cc69d66ff0: Fix T67460: Vertex painting: Sampling color opens empty options window in….

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
59 lines

Diff 16690

View Options

source/blender/editors/interface/interface_region_hud.c

Loading...