Fix for T62917 Selected edge is now highlighted with black and white overlays
ClosedPublic
Actions

Authored by Eitan Traurig (EitanSomething) on Jul 30 2019, 3:16 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
Harley Acheson (harley)
Clément Foucault (fclem)
Germano Cavalcante (mano-wii)
Brecht Van Lommel (brecht)

Commits

rB42cee6ab2134: Fix part of T62917: selected edge not highlighted with black and white overlays

Summary

Fixes issue where selected edge doesn't get highlighted when the overlay is set to black or white.
Need help on:

Add the fix to dash overlay.

Diff Detail

Repository: rB Blender

Event Timeline

Eitan Traurig (EitanSomething) created this revision.Jul 30 2019, 3:16 AM

Harbormaster completed remote builds in B4204: Diff 16669.Jul 30 2019, 3:16 AM

Eitan Traurig (EitanSomething) retitled this revision from Fix for T62917 Fixes issue where selected edge doesn't get highlighted when the overlay is set to black or white. Need help on: - Add the fix to dash overlay. to Fix for T62917.Jul 30 2019, 3:17 AM

Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)

Eitan Traurig (EitanSomething) mentioned this in T62917: UV editor: Edge overlay not shown when edge overlay type is set to 'Dash'.

Eitan Traurig (EitanSomething) added reviewers: Harley Acheson (harley), William Reynish (billreynish).Jul 30 2019, 8:21 PM

Brecht Van Lommel (brecht) edited reviewers, added: Clément Foucault (fclem), Germano Cavalcante (mano-wii); removed: William Reynish (billreynish).Jul 31 2019, 12:04 AM

Note that the dashed outline was the only draw method a long time ago, it may have been kept just to be conservative. If it's a pain to make it work correctly, it could perhaps just get removed.

deduplicate code

Harbormaster completed remote builds in B4222: Diff 16698.Jul 31 2019, 1:40 AM

Nice find!
Overall is good.
Hope you don't mind that I made some minor changes.
Feel free to Commander back the revision ;)

In D5369#121514, @Brecht Van Lommel (brecht) wrote:

Note that the dashed outline was the only draw method a long time ago, it may have been kept just to be conservative. If it's a pain to make it work correctly, it could perhaps just get removed.

I think I understand what I need to change in terms of glsl files

@Campbell Barton (campbellbarton) getting selecting to work with DASH is too complicated for me to do in a timely fashion, can you do that part

This looks good to fix at least the non-dashed cases, just doesn't fix T62917 entirely.

This revision is now accepted and ready to land.Aug 2 2019, 4:22 AM

Eitan Traurig (EitanSomething) retitled this revision from Fix for T62917 to Fix for T62917 Selected edge is now highlighted with black and white overlays.Aug 2 2019, 11:41 PM

When will this be committed?

This comment has been deleted.

Closed by commit rB42cee6ab2134: Fix part of T62917: selected edge not highlighted with black and white overlays (authored by Eitan Traurig (EitanSomething), committed by Brecht Van Lommel (brecht)). · Explain WhyAug 16 2019, 4:49 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB42cee6ab2134: Fix part of T62917: selected edge not highlighted with black and white overlays.