Page MenuHome
Differential D5378

Fix T67808: Bright/Contrast node wrong for negative contrast
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jul 31 2019, 12:59 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)
Maniphest Tasks
T67808: Bright/Contrast node is broken
Commits
rB8dd95abb2ff9: Fix T67808: Bright/Contrast node wrong for negative contrast
Summary

strange nobody noticed since 2012...

thx @Yevgeny Makarov (jenkm) for spotting

Diff Detail

Repository
rB Blender
Branch
T67808 (branched from master)
Build Status
Buildable 4230
Build 4230: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jul 31 2019, 12:59 PM
Harbormaster completed remote builds in B4230: Diff 16712.Jul 31 2019, 12:59 PM
Brecht Van Lommel (brecht) accepted this revision.Jul 31 2019, 1:31 PM
This revision is now accepted and ready to land.Jul 31 2019, 1:31 PM
Philipp Oeser (lichtwerk) added a comment.Jul 31 2019, 2:24 PM

Not sure if we need to do anything to old files? (this will change the look if I am not mistaken...)

Brecht Van Lommel (brecht) added a comment.Jul 31 2019, 2:50 PM

I wouldn't worry about that, it's only for negative contrast and the behavior was just wrong. It's not practical to keep the old formula for backwards compatibility here.

Closed by commit rB8dd95abb2ff9: Fix T67808: Bright/Contrast node wrong for negative contrast (authored by Philipp Oeser (lichtwerk)). · Explain WhyJul 31 2019, 4:38 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB8dd95abb2ff9: Fix T67808: Bright/Contrast node wrong for negative contrast.

Revision Contents
Changeset List

PathSize
source/
blender/
compositor/
operations/
6 lines

Diff 16712

View Options

source/blender/compositor/operations/COM_BrightnessOperation.cpp

Loading...