Fix T67951: Bone selection is broken on some Intel GPUs
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Jul 31 2019, 9:14 PM.

Details

Reviewers

Clément Foucault (fclem)
Brecht Van Lommel (brecht)
Jeroen Bakker (jbakker)

Commits

rBd8fb63661b32: Fix T67951: Bone selection is broken on some Intel GPUs

Summary

The problem is that the glDrawArraysInstancedBaseInstance is ignoring the last parameter.
The solution is to indicate that GLEW_ARB_base_instance is not supported in these cases.

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Jul 31 2019, 9:14 PM

Harbormaster completed remote builds in B4238: Diff 16740.Jul 31 2019, 9:14 PM

Clément Foucault (fclem) accepted this revision.Jul 31 2019, 9:17 PM

This revision is now accepted and ready to land.Jul 31 2019, 9:17 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 31 2019, 9:28 PM

Brecht Van Lommel (brecht) awarded a token.

Closed by commit rBd8fb63661b32: Fix T67951: Bone selection is broken on some Intel GPUs (authored by Germano Cavalcante (mano-wii)). · Explain WhyJul 31 2019, 9:40 PM

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) added a commit: rBd8fb63661b32: Fix T67951: Bone selection is broken on some Intel GPUs.

Adams (cowboyofdeath) added a subscriber: Adams (cowboyofdeath).Aug 13 2019, 2:32 AM

Adams (cowboyofdeath) removed a subscriber: Adams (cowboyofdeath).

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

GPU_extensions.h

1 line

intern/

gpu_batch.c

7 lines

gpu_extensions.c

12 lines

Diff 16743

View Options

source/blender/gpu/GPU_extensions.h

View Options

source/blender/gpu/intern/gpu_batch.c

View Options

source/blender/gpu/intern/gpu_extensions.c

Fix T67951: Bone selection is broken on some Intel GPUsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16743

source/blender/gpu/GPU_extensions.h

source/blender/gpu/intern/gpu_batch.c

source/blender/gpu/intern/gpu_extensions.c

Fix T67951: Bone selection is broken on some Intel GPUs
ClosedPublic
Actions

Revision Contents
Changeset List