Page MenuHome
Differential D5399

Cycles: Add bump-map shadow terminator softening term
ClosedPublic
Actions

Authored by Lukas Stockner (lukasstockner97) on Aug 2 2019, 5:31 AM.
Tags
None
Subscribers
Gabriel Gazzán (gab3d)
Grant Kim (archost)
Manuel Albert (creamsurfer)
Omar Emara (OmarSquircleArt)
Philipp Oeser (lichtwerk)
Tokens
"Like" token, awarded by duarteframos."Party Time" token, awarded by gab3d."Love" token, awarded by jonathanl."Love" token, awarded by SecuoyaEx."Like" token, awarded by billreynish."Like" token, awarded by YAFU."Love" token, awarded by marcog.

Details

Reviewers
Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)
Stefan Werner (swerner)
Commits
rC5ba9ad3e2b99: Add bump map shadow terminator softening term for diffuse BSDFs
rBc3be14e15196: Cycles: add bump map shadow terminator softening term for diffuse BSDFs
Summary

This is an alternative to D4459 that was presented at Siggraph today.

See the paper for comparisons between the two approaches.

Diff Detail

Repository
rB Blender
Branch
bump_terminator (branched from master)
Build Status
Buildable 4255
Build 4255: arc lint + arc unit

Event Timeline

Lukas Stockner (lukasstockner97) created this revision.Aug 2 2019, 5:31 AM
Harbormaster completed remote builds in B4255: Diff 16784.Aug 2 2019, 5:31 AM
Brecht Van Lommel (brecht) added a comment.Aug 2 2019, 9:58 AM

Paper is here: https://www.yiningkarlli.com/projects/shadowterminator/shadow_terminator.pdf

Brecht Van Lommel (brecht) requested changes to this revision.Aug 2 2019, 11:26 AM

Did not test yet, but looks great in the paper.

intern/cycles/kernel/closure/bsdf.h
450

To optimize the the non-bump case and handle transmission, this could be:

else if (label & LABEL_DIFFUSE) {
  if (sc->N != sd->N) {
    *eval *= bump_shadowing_term((label & LABEL_TRANSMIT)? -sd->N : sd->N, sc->N, *omega_in);
  }
}
This revision now requires changes to proceed.Aug 2 2019, 11:26 AM
Marco G (marcog) awarded a token.Aug 5 2019, 7:35 PM
Stefan Werner (swerner) added a comment.Aug 5 2019, 9:04 PM

You beat me to this! :)

Stefan Werner (swerner) added a comment.Aug 6 2019, 12:42 PM

Seems to work as intended:

YAFU (YAFU) awarded a token.Aug 6 2019, 1:12 PM
William Reynish (billreynish) awarded a token.Aug 6 2019, 4:53 PM
SecuoyaEx (SecuoyaEx) awarded a token.Aug 6 2019, 7:22 PM
Jonathan Lampel (jonathanl) awarded a token.Aug 7 2019, 7:09 PM
Manuel Albert (creamsurfer) added a subscriber: Manuel Albert (creamsurfer).Aug 16 2019, 11:39 PM
Brecht Van Lommel (brecht) mentioned this in D4459: Cycles: Added fix for bump terminator problem..Sep 8 2019, 3:36 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 8 2019, 3:52 PM

I'll commit this with the changes for transmission.

This revision is now accepted and ready to land.Sep 8 2019, 3:52 PM
Closed by commit rBc3be14e15196: Cycles: add bump map shadow terminator softening term for diffuse BSDFs (authored by Lukas Stockner (lukasstockner97), committed by Brecht Van Lommel (brecht)). · Explain WhySep 8 2019, 3:52 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBc3be14e15196: Cycles: add bump map shadow terminator softening term for diffuse BSDFs.
Gabriel Gazzán (gab3d) awarded a token.Sep 8 2019, 4:38 PM
Gabriel Gazzán (gab3d) added a subscriber: Gabriel Gazzán (gab3d).
Duarte Farrajota Ramos (duarteframos) awarded a token.Sep 8 2019, 8:51 PM
Grant Kim (archost) added a subscriber: Grant Kim (archost).Sep 9 2019, 3:39 AM
Omar Emara (OmarSquircleArt) added a subscriber: Omar Emara (OmarSquircleArt).Sep 9 2019, 8:28 PM

This breaks OpenCL with the following error:

OpenCL build failed with error CL_BUILD_PROGRAM_FAILURE, errors in console.
OpenCL program split_shadow_blocked_dl build output: source/kernel/closure/bsdf.h:449:5: error: statement requires expression of scalar type ('int __attribute__((ext_vector_type(3)))' (vector of 3 'int' values) invalid)
    if (sc->N != sd->N) {
    ^   ~~~~~~~~~~~~~~
1 error generated.
Brecht Van Lommel (brecht) added a comment.Sep 9 2019, 10:11 PM

Thanks, should be fixed by rB51334dd3a64e: Fix T69686: Cycles OpenCL build error after recent changes.

Stefan Werner (swerner) added a comment.Sep 10 2019, 9:02 AM

I uploaded my sample file if someone needs it in the future for regression testing.

clothbump.blend12 MBDownload

Laurent Noel (c2ba) mentioned this in T68920: Cycles: improve shadow terminator handling.Oct 17 2019, 3:10 PM
Nathan Letwory (jesterking) added a commit: rC5ba9ad3e2b99: Add bump map shadow terminator softening term for diffuse BSDFs.Jan 13 2020, 11:24 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Jan 17 2020, 2:55 PM
In D5399#122343, @Brecht Van Lommel (brecht) wrote:

Paper is here: https://www.yiningkarlli.com/projects/shadowterminator/shadow_terminator.pdf

Just for reference, updating links [older one is dead]
https://www.yiningkarlli.com/projects/shadowterminator.html
https://www.yiningkarlli.com/projects/shadowterminator/shadow_terminator_v1_1.pdf

Stefan Werner (swerner) mentioned this in T37814: Artifacts in Cycles render for lowpoly models..Jan 27 2021, 9:05 AM

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
closure/
28 lines

Diff 16784

View Options

intern/cycles/kernel/closure/bsdf.h

Loading...