Details

Reviewers

Sergey Sharybin (sergey)
Bastien Montagne (mont29)
Ray Molenkamp (LazyDodo)

Commits

rC15c16868d128: Build: disable address sanitizer for Cycles optimized kernels with GCC
rB47bf754de4ec: Build: disable address sanitizer for Cycles optimized kernels with GCC

Summary

It's extremely slow to compile and run, so just disable it. For Clang it's
still enabled since that appears to work ok.

This also limits the -fno-sanitize=vptr flag to the Cycles kernel with GCC
and Clang, since it was added specifically to work around an issue there.
This should solve the issue where this flag was used for MSVC as noted in D5149.

Diff Detail

Repository: rB Blender

Event Timeline

Brecht Van Lommel (brecht) created this revision.Aug 2 2019, 5:34 PM

Harbormaster completed remote builds in B4263: Diff 16802.Aug 2 2019, 5:34 PM

I don't think it's great idea to disable ASAN options for Debug builds.
I don't have issues compiling or running debug kernels with ASAN enabled. And that does help catching some mistakes and bugs.

For RelWithDebInfo and Release it is indeed nice to disable.

This revision now requires changes to proceed.Aug 2 2019, 5:58 PM

Disable only for RelWithDebInfo builds (there is no asan in Release).

For me the Debug kernel.cpp compilation still is very slow though.

gcc 7.4.0: 1.5s
gcc 7.4.0 asan: 123s
clang 6.0.0: 0.3s
clang 6.0.0 asan: 1.3s

Harbormaster completed remote builds in B4266: Diff 16806.Aug 2 2019, 7:26 PM

Brecht Van Lommel (brecht) mentioned this in D5149: CMake: add config for developers.Aug 2 2019, 8:04 PM

Hrm, weird. Can not say i remember such slow compile times, but sounds like it is too annoying for people.

On another hand, i don't like idea of not being able to run kernel with ASAN. Can i talk you into adding WITH_CYCLES_PARANOID_DEBUG option disabled by default and controlling ASAN for debug builds? :)

Disable kernel asan for GCC by default again, add option to enable

Harbormaster completed remote builds in B4280: Diff 16834.Aug 5 2019, 11:46 AM

Is there any harm to remove if(WITH_COMPILER_ASAN) checks? From historical reasons i didn't use it and instead was passing -fsanitize via CMake's CFlags. If we remove the check the new code will "sanitize" compile times for such manually injected cflags as well?