Page MenuHome
Differential D5409

Windows: Remove win32 support from build helpers scripts.
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Aug 3 2019, 5:49 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)
Maniphest Tasks
T67184: End official support for 32 bit builds
Summary

Change is twofold

  1. Make.bat support for x86 has been removed completely, and an error will be displayed when trying to build for 32 bit.
  1. CMake, largely intact, we no longer provide the libs, when an attempt is made to build 32 bits without LIBDIR being set there is a user friendly error message about it.

Diff Detail

Repository
rB Blender
Branch
tmp_win_remove_win32 (branched from master)
Build Status
Buildable 4273
Build 4273: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) created this revision.Aug 3 2019, 5:49 PM
Harbormaster completed remote builds in B4273: Diff 16816.Aug 3 2019, 5:49 PM
Ray Molenkamp (LazyDodo) added a comment.Aug 3 2019, 5:51 PM

Given there is a lib update in the pipeline, i'd rather get this out of the way sooner rather than later, not sure how to link this to T67184 beyond namedropping it.

Brecht Van Lommel (brecht) accepted this revision.Aug 4 2019, 1:48 PM
Brecht Van Lommel (brecht) added a task: T67184: End official support for 32 bit builds.

Tasks can be added with "Edit Related Objects" on the right, but just mentioning it is fine.

The contents of the patch looks fine, but please wait to commit until we've announced this on bf-committers.

This revision is now accepted and ready to land.Aug 4 2019, 1:49 PM
Brecht Van Lommel (brecht) added a comment.Aug 5 2019, 11:28 AM

We announced it on bf-committers now, 32 bit buildbots go offline today, this should be ok to commit.

Brecht Van Lommel (brecht) mentioned this in T67184: End official support for 32 bit builds.Aug 5 2019, 11:35 AM
Ray Molenkamp (LazyDodo) closed this revision.Aug 5 2019, 6:35 PM
Ray Molenkamp (LazyDodo) mentioned this in rB64b092974c71: Cleanup/windows: Remove 32 bit support from make.bat helper script.

landed in rB64b092974c71

Revision Contents
Changeset List

PathSize
build_files/
cmake/
platform/
6 lines
windows/
6 lines
10 lines
10 lines
4 lines
11 lines
2 lines
1 line

Diff 16816

View Options

build_files/cmake/platform/platform_win32.cmake

Loading...
View Options

build_files/windows/check_libraries.cmd

Loading...
View Options

build_files/windows/configure_msbuild.cmd

Loading...
View Options

build_files/windows/detect_architecture.cmd

Loading...
View Options

build_files/windows/format.cmd

Loading...
View Options

build_files/windows/parse_arguments.cmd

Loading...
View Options

build_files/windows/show_help.cmd

Loading...
View Options

make.bat

Loading...