Details
Diff Detail
Event Timeline
Some first comments, mostly cleanup related:
| .gitignore | ||
|---|---|---|
| 1 | These should be ommited in final patch. | |
| release/scripts/startup/bl_ui/properties_data_modifier.py | ||
| 242 | Commented code here should be ommited as well in final patch | |
| source/blender/modifiers/intern/MOD_morphtarget.c | ||
| 144 | You could reuse this below | |
| 165 | Nitpicking, stick to our comment style please (no C++ style comments, space between comment symbols and text. See our wiki for more details) | |
| 177 | Unused, shoud be cleaned-up | |
| 193 | getNumVerts() is the function you are looking for here. Also NULL check should be first or first check may crash. I don't think NULL derived mesh could happen though. @Sergey Sharybin (sergey) is it possible for this to race for derived mesh data or will the dependency graph handle this correctly? | |
| 200 | second NULL check for object is superfluous | |
| 208 | You can move this to an else block below where you check for MOD_TARGETMORPH_USE_MODIFIED to avoid copying twice | |
| 217 | Nitpicking, spacing | |
| 232 | Again, first check is superfluous. You can also check for cmd->object != ob on the deformVerts functions below, before entering here. Also, shouldn't this be an else if? The modifier would be applied twice otherwise | |
Thanks for the revisions, I appreciate that you took time to offer support. I am addressing them as of now. I am going to release a new diff soon
cheers
k
Hi
Here us the updated patch. Hopefully I managed to address the issues proportionally.
thanks