In D5442#148272, @Paul Hartsuyker (paulhart) wrote:

In D5442#148082, @YimingWu (NicksBest) wrote:

Up to date with latest origin/master

use temp-lanpr-review branch to compile.

I am now able to use the temp-lanpr-review with git. I noted that current builds from "Experimental Builds" are incremented to Blender 2.82.6 from the buildbot, but the builds from this LANPR Branch only reference Blender 2.82.4

Is this correct?? from your understanding?

Trying to keep the builds contemporary to development progress. Great to see all of the effort. Thank you one and all.

So, I've been trying to review this, but am unable to get LANPR to actually display any lines. I've tested it on several different Macs here and all I see is a blank viewport. And when I go to add a new line layer, I get a segfault 11 every time.

It's possible that the issue is OS-specific, or that there is some other issue. If anyone has a moment to check if LANPR works ok on Mac, it'd be much appreciated. Thanks.

Hi @YimingWu (NicksBest) could you please use arcanist to update this patch? At the moment I cannot even try to build it with I do arc patch D5442

@Jeroen Bakker (jbakker):

I tried the quick setup, but that only showed me a black rendered viewport

I believe you need to enable "Auto Update" (or manually update it).

That said I did not manage to get this working combined with EEVEE or Cycles. Even after enabling it in the Cycles and EEVEE panels.

Currently LANPR is a render engine choice, to be made 'first' before any of the options. It doesn't work with Cycles or EeVee, but is independent, not 'integrated' like Freestyle, which is a "Post-Render" extra render process. Current build only includes 2.82.4 Blender, and does not include many of the more "Artistic" features and integration of Freestyle elements. It is also 'under-documented' regarding what options need to be turned on for which effect. I was hoping that it would be prioritized for the 2.83 release cycles, with these elements corrected, but the most recent Developer Notes make no mention of LANPR.

In D5442#154186, @Paul Hartsuyker (paulhart) wrote:

Currently LANPR is a render engine choice, to be made 'first' before any of the options. It doesn't work with Cycles or EeVee, but is independent, not 'integrated' like Freestyle, which is a "Post-Render" extra render process. Current build only includes 2.82.4 Blender, and does not include many of the more "Artistic" features and integration of Freestyle elements. It is also 'under-documented' regarding what options need to be turned on for which effect. I was hoping that it would be prioritized for the 2.83 release cycles, with these elements corrected, but the most recent Developer Notes make no mention of LANPR.

Most functions work as expected but linking/appending scenes and collections causes the build to crash.

In D5442#154186, @Paul Hartsuyker (paulhart) wrote:

Currently LANPR is a render engine choice, to be made 'first' before any of the options. It doesn't work with Cycles or EeVee, but is independent, not 'integrated' like Freestyle, which is a "Post-Render" extra render process. Current build only includes 2.82.4 Blender, and does not include many of the more "Artistic" features and integration of Freestyle elements. It is also 'under-documented' regarding what options need to be turned on for which effect. I was hoping that it would be prioritized for the 2.83 release cycles, with these elements corrected, but the most recent Developer Notes make no mention of LANPR.

This may be the reason that William and others couldn't get the MAC build to display (assuming that there is a current build for MAC??), as they were not choosing the LANPR Render Engine 'first' before any of the options. This is also why a more comprehensive documentation, perhaps by someone else on the review team might help. It is disappointing to see this project 'slip' past the 2.83 window, and no 'Real Time' enhancements of Freestyle, or better integration of Freestyle artistic choices and current omissions:
GPencil modifiers.
Smooth contour modifier.
SVG.
Affected UI scripts.
Freestyle changes.

I've also tried to build this for Mac. I've used the temp-lanpr-review branch, which I guess contains all latest changes. However, just by adding LANPR layers (using the Default button) and trying to Update while in "Render preview" Viewport shading mode I get the following errors:

GPUShader: compile error:
ERROR: 0:388: Use of undeclared identifier 'gl_FragData'
ERROR: 0:389: Use of undeclared identifier 'gl_FragData'
ERROR: 0:392: Use of undeclared identifier 'gl_FragData'
ERROR: 0:406: Use of undeclared identifier 'gl_FragData'
ERROR: 0:407: Use of undeclared identifier 'gl_FragData'
ERROR: 0:408: Use of undeclared identifier 'gl_FragData'
ERROR: 0:422: Use of undeclared identifier 'gl_FragData'
ERROR: 0:423: Use of undeclared identifier 'gl_FragData'
ERROR: 0:424: Use of undeclared identifier 'gl_FragData'
ERROR: 0:447: Use of undeclared identifier 'gl_FragData'
ERROR: 0:448: Use of undeclared identifier 'gl_FragData'
ERROR: 0:449: Use of undeclared identifier 'gl_FragData'
ERROR: 0:475: Use of undeclared identifier 'gl_FragData'
ERROR: 0:477: Use of undeclared identifier 'gl_FragData'

LANPR: DPIX transform shader compile error.GPUShader: compile error:
ERROR: 0:14: Use of undeclared identifier 'gl_FragData'

LANPR: DPIX transform shader compile error.GPUShader: compile error:
ERROR: 0:14: Use of undeclared identifier 'gl_FragData'

GPUShader: compile error:
ERROR: 0:14: Use of undeclared identifier 'gl_FragData'

There is also a backtrace, although I'm not sure how useful it is:

# backtrace
0   Blender                             0x000000010aa9ff57 BLI_system_backtrace + 55
1   Blender                             0x0000000104a4a739 sig_handle_crash + 361
2   libsystem_platform.dylib            0x00007fff62b05b5d _sigtramp + 29
3   ???                                 0x0000000000000000 0x0 + 0
4   Blender                             0x0000000108d8ebb7 drw_shgroup_init + 55
5   Blender                             0x0000000108d8f3d9 DRW_shgroup_create + 105
6   Blender                             0x0000000108de1ea2 lanpr_software_draw_scene + 1762
7   Blender                             0x0000000108de122e lanpr_draw_scene_exec + 222
8   Blender                             0x0000000108d8a12d drw_engines_draw_scene + 173
9   Blender                             0x0000000108d894c7 DRW_draw_render_loop_ex + 1607
10  Blender                             0x000000010921ab8d view3d_main_region_draw + 125
11  Blender                             0x00000001090025ca ED_region_do_draw + 362
12  Blender                             0x0000000104ecad7b wm_draw_update + 1899
13  Blender                             0x0000000104ec89a0 WM_main + 48
14  Blender                             0x0000000104a46f76 main + 934
15  libdyld.dylib                       0x00007fff6291a3d5 start + 1
16  ???                                 0x0000000000000001 0x0 + 1

In D5442#152697, @William Reynish (billreynish) wrote:

So, I've been trying to review this, but am unable to get LANPR to actually display any lines. I've tested it on several different Macs here and all I see is a blank viewport. And when I go to add a new line layer, I get a segfault 11 every time.

It's possible that the issue is OS-specific, or that there is some other issue. If anyone has a moment to check if LANPR works ok on Mac, it'd be much appreciated. Thanks.

Building and testing temp-lanpr-review branch on osx (on different macs) can confirm the issues. Clicking on render image will render out the image correctly including lanpr lines though.

Updating grease pencil target isn't working anymore.
Used to work on soc-2019-npr branch.

All other issues (not rendering lines in viewport and crashing using LANPR as main renderer in render view mode) were already present back then.

Disregard . . I just updated my SVN and CMAKE to the latest versions and it builds correctly.

I encountered an error two(2) days ago, while trying to do the Win64 build for GraphicAll.org. It was not able to find LLVMX86AsmPrinter.lib. Now I had a different error, it could not find clangToolRefactor.lib. I will try again tomorrow, as I am overdue to post a new build to the community, and I don't know how to correct these kind of errors. Any help? Thank you all for the continued development efforts.

Looks like there are some files are affected with wrong modifications as well. Let me fix those.