Nodes: Display vector values expanded, except when specified as compact.
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Aug 10 2019, 4:31 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Jacques Lucke (JacquesLucke)

Commits

rB26911ba1e26b: Nodes: Display vector values expanded, except when specified as compact.

Summary

This patch changes the default drawing method of the vector sockets to use a column layout.
This allows more interactive use of nodes and avoids the one or two clicks needed to edit vectors
in the old default component layout.

Developers may still use the component layout by using the SOCK_COMPACT socket flag.
For now, we choose to draw the SSS scale vector of the Principled and SSS nodes in a compact
form because they don't require much interactivity.

Diff Detail

Repository: rB Blender

Event Timeline

Omar Emara (OmarSquircleArt) created this revision.Aug 10 2019, 4:31 PM

Harbormaster completed remote builds in B4372: Diff 17020.Aug 10 2019, 4:31 PM

Omar Emara (OmarSquircleArt) edited the summary of this revision. (Show Details)Aug 10 2019, 4:33 PM

Looks good, you can commit this to master.

For the commit message, make sure to read the guidelines carefully.
https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

In this case, I would change the subject line to "Nodes: display vector values expanded, except when specified as compact"

This revision is now accepted and ready to land.Aug 10 2019, 5:00 PM

Omar Emara (OmarSquircleArt) retitled this revision from GSoC: Change the default vector socket drawing method and introduce compact sockets. to Nodes: Display vector values expanded, except when specified as compact..Aug 10 2019, 5:12 PM

Jacques Lucke (JacquesLucke) accepted this revision.Aug 10 2019, 5:16 PM

Closed by commit rB26911ba1e26b: Nodes: Display vector values expanded, except when specified as compact. (authored by Omar Emara (OmarSquircleArt)). · Explain WhyAug 10 2019, 5:57 PM

This revision was automatically updated to reflect the committed changes.

Omar Emara (OmarSquircleArt) added a commit: rB26911ba1e26b: Nodes: Display vector values expanded, except when specified as compact..

Omar Emara (OmarSquircleArt) mentioned this in T68823: GSoC 2019 - Cycles/EEVEE Improvements.Aug 19 2019, 1:35 PM