Page MenuHome
Differential D5466

GPencil: Proposed fix for T68507 - Show always the Select Menu in Edit Mode
ClosedPublic
Actions

Authored by Matias Mendiola (mendio) on Aug 12 2019, 10:28 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
William Reynish (billreynish)
Commits
rBaf3f0bf9d4f0: Fix T68507: Gpencil: Show always the Select Menu in Edit Mode
Summary

Control the visibility of the Select Menu with selection mask button only if in Sculpt Mode

Diff Detail

Event Timeline

Matias Mendiola (mendio) created this revision.Aug 12 2019, 10:28 PM
Antonio Vazquez (antoniov) added inline comments.Aug 12 2019, 11:02 PM
release/scripts/startup/bl_ui/space_view3d.py
735

If you have only one string use instead:

if mode_string == 'SCULPT_GPENCIL' and ts.gpencil_sculpt.use_select_mask:

The in is used only when you have a list of values.

737

Same as above

Antonio Vazquez (antoniov) requested changes to this revision.Aug 12 2019, 11:03 PM
This revision now requires changes to proceed.Aug 12 2019, 11:03 PM
Matias Mendiola (mendio) updated this revision to Diff 17058.Aug 12 2019, 11:13 PM

Code optimization

Antonio Vazquez (antoniov) accepted this revision.Aug 12 2019, 11:21 PM
This revision is now accepted and ready to land.Aug 12 2019, 11:21 PM
William Reynish (billreynish) accepted this revision.Aug 12 2019, 11:21 PM
Closed by commit rBaf3f0bf9d4f0: Fix T68507: Gpencil: Show always the Select Menu in Edit Mode (authored by Matias Mendiola (mendio), committed by Antonio Vazquez (antoniov)). · Explain WhyAug 12 2019, 11:22 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rBaf3f0bf9d4f0: Fix T68507: Gpencil: Show always the Select Menu in Edit Mode.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
4 lines

Diff 17056

View Options

release/scripts/startup/bl_ui/space_view3d.py

Loading...