Shading: Add Map Range node to Cycles and EEVEE.
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Aug 13 2019, 2:45 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Jacques Lucke (JacquesLucke)

Commits

rC704ef201d787: Shading: Add Map Range node to Cycles and EEVEE
rB71641ab56d0f: Shading: Add Map Range node to Cycles and EEVEE.

Summary

This patch adds a new Map Range node that linearly remaps an input
value from a range to another. This node is similar to the compositor's
Map Range node.

Diff Detail

Repository

rB Blender

Branch

map-range-node (branched from master)

Build Status

Buildable 4397
Build 4397: arc lint + arc unit

Event Timeline

Omar Emara (OmarSquircleArt) created this revision.Aug 13 2019, 2:45 PM

Harbormaster completed remote builds in B4397: Diff 17068.Aug 13 2019, 2:45 PM

Seems to work fine, I cannot see any mistakes.

This revision is now accepted and ready to land.Aug 13 2019, 3:18 PM

Looks great, just one minor comment.

intern/cycles/render/nodes.cpp
5268–5272	These socket names should be from_min, from_max, ... the convention is to use snake case instead of camel case here.

This revision now requires changes to proceed.Aug 13 2019, 3:28 PM

Use standard naming convention.

Harbormaster completed remote builds in B4402: Diff 17073.Aug 13 2019, 3:40 PM

This can go into master.

From a suggestion by @Ray Molenkamp (LazyDodo), I think it would be important to add a Clamp option for this node.

It doesn't have to be done as part of this patch, but would be good to add after since it's probably what you want at least half the time.

This revision is now accepted and ready to land.Aug 13 2019, 4:15 PM

In D5471#124576, @Brecht Van Lommel (brecht) wrote:

This can go into master.

From a suggestion by @Ray Molenkamp (LazyDodo), I think it would be important to add a Clamp option for this node.

It doesn't have to be done as part of this patch, but would be good to add after since it's probably what you want at least half the time.

To clamp the output to the [0, 1] range? We have a dedicated Clamp node for this, will add a patch for it next.

I guess to clamp to To Min and To Max. I agree, it makes sense to have this option in this node (at least it makes much more sense than in the math node).

In D5471#124590, @Jacques Lucke (JacquesLucke) wrote:

I guess to clamp to To Min and To Max. I agree, it makes sense to have this option in this node (at least it makes much more sense than in the math node).

Ah ok. Will do.

Closed by commit rB71641ab56d0f: Shading: Add Map Range node to Cycles and EEVEE. (authored by Omar Emara (OmarSquircleArt)). · Explain WhyAug 13 2019, 4:38 PM

This revision was automatically updated to reflect the committed changes.

Omar Emara (OmarSquircleArt) added a commit: rB71641ab56d0f: Shading: Add Map Range node to Cycles and EEVEE..

Omar Emara (OmarSquircleArt) mentioned this in T68823: GSoC 2019 - Cycles/EEVEE Improvements.Aug 19 2019, 1:35 PM

Brecht Van Lommel (brecht) added a commit: rC704ef201d787: Shading: Add Map Range node to Cycles and EEVEE.Aug 22 2019, 5:20 PM

Charlie Jolly (charlie) mentioned this in T72337: Shader Node Additions.Dec 10 2019, 6:53 PM