Details

Outdated, and we don't really have problems in this area.
We can use debug tools like renderdoc for the same purpose.
So this patch is not seen really essential.

Update

For issues like T81266 this patch is important.

This revision is now accepted and ready to land.Aug 3 2021, 5:55 PM

Harbormaster completed remote builds in B16192: Diff 40272.Aug 3 2021, 5:55 PM

Clément Foucault (fclem) accepted this revision.Aug 3 2021, 9:15 PM

Clément Foucault (fclem) added inline comments.

source/blender/draw/engines/select/select_debug_engine.c
93	Nitpick, you can draw one procedural triangle instead of using the fullscreen quad batch.

Call DRW_shgroup_call_procedural_triangles
Add WITH_DRAW_DEBUG Cmake option

One thing that keeps me from committing this patch is that this code won't be useful to the end user.
So, in order not to add useless code to a non-developer user, I created the Cmake option WITH_DRAW_DEBUG.
So this engine is only used for development.

Harbormaster completed remote builds in B16244: Diff 40357.Aug 5 2021, 3:06 PM

Clément Foucault (fclem) accepted this revision.Aug 5 2021, 3:47 PM

Philipp Oeser (lichtwerk) awarded a token.Aug 5 2021, 4:04 PM

Closed by commit rBcc4e674e41f9: DRW: New Select Debug Engine (authored by Germano Cavalcante (mano-wii)). · Explain WhyAug 5 2021, 5:07 PM

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) added a commit: rBcc4e674e41f9: DRW: New Select Debug Engine.