Fix T56408: Hair children recalc on every frame on Alembic mesh
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Aug 15 2019, 6:19 PM.

Details

Reviewers

Bastien Montagne (mont29)
Brecht Van Lommel (brecht)

Commits

rBee8aad79c159: Fix T56408: Hair children recalc on every frame on Alembic mesh

Summary

This fixes the glitching hairs described in T56408.

The fix consists of returning the original mesh (i.e. as visible in edit mode) when constructing the ORCO mesh. This allows a static set of coordinates to be used when computing the child hair positions.

The original mesh is only returned when it has the same topology (at least same number of vertices, loops, and polys.

Diff Detail

Repository: rB Blender

Event Timeline

Sybren A. Stüvel (sybren) created this revision.Aug 15 2019, 6:19 PM

Harbormaster completed remote builds in B4448: Diff 17165.Aug 15 2019, 6:19 PM

Brecht Van Lommel (brecht) accepted this revision.Aug 16 2019, 1:42 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/alembic/intern/abc_mesh.cc
1154–1156	Strictly speaking you have to compare the `mpoly` array to be sure, you can have different topology with same number of vertices and polygons. But this is existing code so don't think it's a blocker for this fix.