Page MenuHome

Fix T68700: Incorrect 'absolute' timing of animated masks in the Video Sequence Editor
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Aug 15 2019, 8:35 PM.

Details

Summary

Code in seq_render_mask will effectively do BKE_mask_evaluate(mask_temp, mask->sfra + (cfra - fra_offset), true) where fra_offset is zero for absolute and seq->start for relative.

If we really want the scene's current frame (as advertised) if Mask Time is set to Absolute (effectively ignoring the Mask Settings start/end) we need to change the fra_offset from zero to mask->sfra.

Also BKE_animsys_evaluate_animdata should take mask->sfra into account as well (otherwise mask animation [points] and other animation [e.g. opacity] will run out of sync)

Diff Detail

Repository
rB Blender

Event Timeline

This revision is now accepted and ready to land.Aug 19 2019, 10:45 AM

just noticed BKE_animsys_evaluate_animdata should take mask->sfra into account as well (otherwise mask animation [points] and other animation [e.g.opacity] will run out of sync)

Philipp Oeser (lichtwerk) requested review of this revision.Oct 1 2019, 2:22 PM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)

I know this has been accepted already, but could you check again for recent change as well? thx

This revision is now accepted and ready to land.Oct 14 2019, 12:36 PM