These variants are implemented mainly for LANPR to run smoothly with its double precision internal calculations.
Matrix multiply function needs a new __SSE2__ implementation.
Details
Details
Diff Detail
Diff Detail
Event Timeline
| source/blender/blenlib/intern/math_matrix.c | ||
|---|---|---|
| 277 | I guess this is just a matter of __m128 -> __m128d and _ps -> _pd everywhere? | |
| source/blender/blenlib/intern/math_matrix.c | ||
|---|---|---|
| 277 | B is a float[4][4] mat rather than a double one, so this way it might break _mm_mul_ps I'm changing my matrix to use double only for simplicity, but some other problems popped up as well. I'm probably going to add a mul_m4_m4m4_db_uniq() where all three matrices are double pricision. Maybe use the SSE instructions only with pure double situations and leave this one without SSE? (Or I remove this variant completely) | |
| source/blender/blenlib/intern/math_matrix.c | ||
|---|---|---|
| 277 | Right, it can copy float to double without SSE, and then run the multiplication with doubles only. | |
| source/blender/blenlib/intern/math_matrix.c | ||
|---|---|---|
| 277 | OK. I'll make a double copy first and use SSE. Thanks! | |
Comment Actions
updated two finctions mul_m4_m4m4_db_uniq() and mul_m4db_m4db_m4fl_uniq() for __SSE2__ support.
Comment Actions
__m128d is double[2] instead of double[4], but __m256d needs AVX support. I removed SIMD instructions for those and leave the optimization to the compiler. double version of the matrix is not frequently called, there should be little performance impact on this.
Comment Actions
This patch has an approved status however it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect this. This way the patch status still show as Need Review.
Though in this case we can probably just drop this?