GPencil: Split Select mode for Sculpt and Edit mode
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Aug 16 2019, 11:45 AM.

Details

Reviewers

Matias Mendiola (mendio)
Daniel Martinez Lara (pepeland)

Commits

rB85f90ed6fd88: Fix T68723: GPencil - Split Select mode for Sculpt and Edit mode

Summary

Actually, the selection mode is not visible in Sculpt mode when mask is enabled, but still is used.

Also, the mode is shared between Edit mode and Sculpt mode and for meshes the selector is by mode.

This patch splits the select mode in different properties and show the selector in Sculpt mode to define the Select mode. Also, the Select Mask button has been removed and now the Select Mode buttons work equal to Meshes where the select buttons are the mask enable too.

Fixed some old code not valid detected during these changes.

Diff Detail

Repository: rB Blender

Event Timeline

Antonio Vazquez (antoniov) created this revision.Aug 16 2019, 11:45 AM

Harbormaster completed remote builds in B4458: Diff 17183.Aug 16 2019, 11:45 AM

Antonio Vazquez (antoniov) mentioned this in T68723: GPencil: Split Select Mode buttons for Edit and Sculpt modes.Aug 16 2019, 11:46 AM

Antonio Vazquez (antoniov) added reviewers: Matias Mendiola (mendio), Daniel Martinez Lara (pepeland).

GPencil: Remove old code not used
GPencil: Remove mask button for Sculpt and use Select Modes
GPencil: More work to decouple Select modes

Harbormaster completed remote builds in B4465: Diff 17195.Aug 16 2019, 4:35 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Aug 16 2019, 4:38 PM

Antonio Vazquez (antoniov) mentioned this in D5504: Minor cleanups.Aug 16 2019, 5:07 PM

Thanks @Antonio Vazquez (antoniov) , all seems to work ok. With this change Grease Pencil is now more consistent on how Blender works with selection masking in other objects

I updated the diff, and ARC created an update of this revision, instead of update it (D5504). I keep this revision because the changes were small and I will commit manually, not applying this revisión, so the final commit will be slightly different (small cleanup).

Antonio Vazquez (antoniov) added inline comments.Aug 16 2019, 5:14 PM

source/blender/makesdna/DNA_scene_types.h
1128	Final commit the line will be: `GP_SCULPT_SETT_FLAG_DEPRECATED = (1 << 0),`

Matias Mendiola (mendio) accepted this revision.Aug 16 2019, 5:16 PM

This revision is now accepted and ready to land.Aug 16 2019, 5:16 PM

tested and it is working fine

GPencil: Fix wrong mask flag checking for limit Sculpt

Harbormaster completed remote builds in B4477: Diff 17226.Aug 17 2019, 1:22 PM

Please, @Matias Mendiola (mendio) and @Daniel Martinez Lara (pepeland) verify now it's impossible sculpt not selected points when mask was enabled, I have detected a problem in that code and fixed.

Closed by commit rB85f90ed6fd88: Fix T68723: GPencil - Split Select mode for Sculpt and Edit mode (authored by Antonio Vazquez (antoniov)). · Explain WhyAug 17 2019, 4:27 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rB85f90ed6fd88: Fix T68723: GPencil - Split Select mode for Sculpt and Edit mode.