Fix T68710: crash on applying modifier after shape keys are removed
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 16 2019, 12:55 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)

Maniphest Tasks

T68710: 2.80 Segfault on applying modifier after shape keys are removed

Commits

rB13c9df10a8fd: Fix T68710: crash on applying modifier after removing all shape keys

Summary

This was a mistake in rB87629b2a7443

BKE_object_shapekey_free would never return true, so DEG updates
would not happen...
So ob->shapenr was not up-to-date etc., leading to crash in
BKE_mesh_nomain_to_mesh shapekey handling...

Diff Detail

Repository

rB Blender

Branch

T68710 (branched from master)

Build Status

Buildable 4459
Build 4459: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Aug 16 2019, 12:55 PM

Harbormaster completed remote builds in B4459: Diff 17184.Aug 16 2019, 12:55 PM

Brecht Van Lommel (brecht) accepted this revision.Aug 16 2019, 1:24 PM

This revision is now accepted and ready to land.Aug 16 2019, 1:24 PM

Closed by commit rB13c9df10a8fd: Fix T68710: crash on applying modifier after removing all shape keys (authored by Philipp Oeser (lichtwerk)). · Explain WhyAug 16 2019, 2:01 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB13c9df10a8fd: Fix T68710: crash on applying modifier after removing all shape keys.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

object.c

2 lines

Diff 17184

View Options

source/blender/blenkernel/intern/object.c

Fix T68710: crash on applying modifier after shape keys are removedClosedPublicActions