Paths

Table of Contentst

Fix T68702: Input socket in the Normal node isn't drawn properly.
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Aug 16 2019, 4:10 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Jacques Lucke (JacquesLucke)

Commits

rB25f1783673de: Fix T68702: Input socket in the Normal node isn't drawn properly.

Summary

The Normal vector socket in the Normal node wasn't drawn properly and
couldn't be controlled. Additionally, the socket name was drawn over it.

This happened because the socket had a default value of a zero vector.
To fix this, we set the default value to the unit vector (0, 0, 1).
Moreover, we don't draw the UI name if the subtype is PROP_DIRECTION.

Diff Detail

Repository

rB Blender

Branch

fix-direction-vector-socket (branched from master)

Build Status

Buildable 4463
Build 4463: arc lint + arc unit

Event Timeline

Omar Emara (OmarSquircleArt) created this revision.Aug 16 2019, 4:10 PM

Harbormaster completed remote builds in B4463: Diff 17193.Aug 16 2019, 4:10 PM

Brecht Van Lommel (brecht) accepted this revision.Aug 16 2019, 4:18 PM

This revision is now accepted and ready to land.Aug 16 2019, 4:18 PM

Brecht Van Lommel (brecht) requested changes to this revision.Aug 16 2019, 4:19 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/nodes/shader/nodes/node_shader_normal.c
28	Actually, this seems wrong? Why did it change?

This revision now requires changes to proceed.Aug 16 2019, 4:19 PM

Brecht Van Lommel (brecht) added inline comments.Aug 16 2019, 4:19 PM

source/blender/nodes/shader/nodes/node_shader_normal.c
28	It' supposed to be a unit vector by default, not zero.

Nevermind, I'm blind :)

This revision is now accepted and ready to land.Aug 16 2019, 4:20 PM

Closed by commit rB25f1783673de: Fix T68702: Input socket in the Normal node isn't drawn properly. (authored by Omar Emara (OmarSquircleArt)). · Explain WhyAug 16 2019, 5:59 PM

This revision was automatically updated to reflect the committed changes.

Omar Emara (OmarSquircleArt) added a commit: rB25f1783673de: Fix T68702: Input socket in the Normal node isn't drawn properly..

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_node/

drawnode.c

9 lines

nodes/

shader/

nodes/

node_shader_normal.c

2 lines

Diff 17193

View Options

source/blender/editors/space_node/drawnode.c