Page MenuHome

Fix T68852: Link select make crash when after knife project
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Aug 20 2019, 12:02 PM.

Details

Summary

Knife project switches out of vertex selection mode, but wouldnt do this
for all participating meshes.
Logic in edbm_select_linked_pick would switch the viewcontext multiple
times and the meshes selectmode was not in sync then, e.g.
finding a vertex in 'unified_findnearest' (because last of the meshes
selectmode was SCE_SELECT_VERTEX), but then later in
'EDBM_elem_from_selectmode' other meshes selectmode was not matching
SCE_SELECT_VERTEX, leading to crash...

Diff Detail

Repository
rB Blender
Branch
T68852 (branched from master)
Build Status
Buildable 4511
Build 4511: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 19 2019, 10:57 AM

Suggest to add EDBM_selectmode_disable_multi, similar to EDBM_mesh_deselect_all_multi & EDBM_mesh_deselect_all, so other similar uses don't need to be done in a loop.

Also, selected_objects isn't a reliable way to handle this case - since objects can be in edit-mode & not selected.