Page MenuHome
Differential D5542

Rename cut operator
ClosedPublic
Actions

Authored by Nathan Lovato (gdquest) on Aug 20 2019, 5:06 PM.

Details

Reviewers
Richard Antalik (ISS)
William Reynish (billreynish)
Maniphest Tasks
T68690: Cut function in sequencer confused with copy and paste and should be renamed into Split
Commits
rB819af2094b21: Rename Sequencer 'Cut' to 'Split'
Summary

Closes https://developer.blender.org/T68690

I've only renamed the operator in Blender. Should I rename cut->split in sequencer_edit.c for consistency with the source code?

Diff Detail

Repository
rB Blender
Branch
sequencer_rename_cut (branched from master)
Build Status
Buildable 4521
Build 4521: arc lint + arc unit

Event Timeline

Nathan Lovato (gdquest) created this revision.Aug 20 2019, 5:06 PM
Harbormaster completed remote builds in B4520: Diff 17308.Aug 20 2019, 5:06 PM
Nathan Lovato (gdquest) edited the summary of this revision. (Show Details)Aug 20 2019, 5:11 PM
Nathan Lovato (gdquest) added a reviewer: Richard Antalik (ISS).
Nathan Lovato (gdquest) added a project: Video Sequencer.
Nathan Lovato (gdquest) updated this revision to Diff 17309.Aug 20 2019, 5:12 PM

Rename cut operator function to split

Harbormaster completed remote builds in B4521: Diff 17309.Aug 20 2019, 5:12 PM
Nathan Lovato (gdquest) mentioned this in T68690: Cut function in sequencer confused with copy and paste and should be renamed into Split.Aug 20 2019, 5:18 PM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).Aug 20 2019, 10:54 PM

Yes, should be renamed in internal code too, the keymap needs updating.

Nathan Lovato (gdquest) updated this revision to Diff 17331.Aug 21 2019, 8:39 AM

Rename cut->split in source code, rename cut multicam to split, update keymap

Harbormaster completed remote builds in B4532: Diff 17331.Aug 21 2019, 8:39 AM
Nathan Lovato (gdquest) added a comment.Aug 21 2019, 8:44 AM

I also renamed cut_multicam to split_muticam, compiled and tested in the vse
I went ahead and renamed all cutframe variables to split_frame, even in cut_seq_list as it's used in the split functions.

Eitan Traurig (EitanSomething) awarded a token.Aug 22 2019, 4:28 AM
Philipp Oeser (lichtwerk) added a task: T68690: Cut function in sequencer confused with copy and paste and should be renamed into Split.Dec 20 2019, 11:43 AM
Eitan Traurig (EitanSomething) added a subscriber: Eitan Traurig (EitanSomething).Jan 9 2020, 12:20 AM

Everything looks good to me, but am not able to test at the moment.

Eitan Traurig (EitanSomething) mentioned this in D6612: Manual:Rename cut operator to split.Jan 17 2020, 6:19 PM
Eitan Traurig (EitanSomething) added a child revision: D6612: Manual:Rename cut operator to split.
Eitan Traurig (EitanSomething) updated this revision to Diff 21398.Feb 4 2020, 8:52 PM
  • Update to master
Harbormaster completed remote builds in B6492: Diff 21398.Feb 4 2020, 8:52 PM
Eitan Traurig (EitanSomething) updated this revision to Diff 21405.Feb 4 2020, 10:41 PM
  • Fix code issue
Harbormaster completed remote builds in B6494: Diff 21405.Feb 4 2020, 10:41 PM
Brecht Van Lommel (brecht) added a reviewer: William Reynish (billreynish).Feb 4 2020, 11:05 PM
William Reynish (billreynish) accepted this revision.Feb 5 2020, 10:52 AM

Fine with this. This removes the ambiguity between it and Cut/Copy/Paste.

This revision is now accepted and ready to land.Feb 5 2020, 10:52 AM
Closed by commit rB819af2094b21: Rename Sequencer 'Cut' to 'Split' (authored by William Reynish (billreynish)). · Explain WhyFeb 16 2020, 9:39 PM
This revision was automatically updated to reflect the committed changes.
William Reynish (billreynish) added a commit: rB819af2094b21: Rename Sequencer 'Cut' to 'Split'.
Eitan Traurig (EitanSomething) removed a child revision: D6612: Manual:Rename cut operator to split.Feb 24 2020, 10:15 PM
Eitan Traurig (EitanSomething) mentioned this in rBM6298: Manual:Rename cut operator to split.Mar 2 2020, 4:19 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_sequencer/
8 lines
2 lines
2 lines

Diff 17309

View Options

source/blender/editors/space_sequencer/sequencer_edit.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_intern.h

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_ops.c

Loading...