Fix T69044: OpenCL fail due to bad fract function.
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Aug 22 2019, 1:36 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Jacques Lucke (JacquesLucke)

Commits

rC89cb9a6f74b2: Fix T69044: OpenCL fail due to bad fract function
rBc6f8ea7b45af: Fix T69044: OpenCL fail due to bad fract function.

Summary

The fract function in OpenCL does more than just return the fraction.
We use a simple a - floor(a) instead like the Math node.

Diff Detail

Repository

rB Blender

Branch

fix-opencl-fract-function (branched from master)

Build Status

Buildable 4544
Build 4544: arc lint + arc unit

Event Timeline

Omar Emara (OmarSquircleArt) created this revision.Aug 22 2019, 1:36 PM

Harbormaster completed remote builds in B4544: Diff 17362.Aug 22 2019, 1:36 PM

Brecht Van Lommel (brecht) accepted this revision.Aug 22 2019, 1:44 PM

This revision is now accepted and ready to land.Aug 22 2019, 1:44 PM

Closed by commit rBc6f8ea7b45af: Fix T69044: OpenCL fail due to bad fract function. (authored by Omar Emara (OmarSquircleArt)). · Explain WhyAug 22 2019, 1:50 PM

This revision was automatically updated to reflect the committed changes.

Omar Emara (OmarSquircleArt) added a commit: rBc6f8ea7b45af: Fix T69044: OpenCL fail due to bad fract function..

Brecht Van Lommel (brecht) added a commit: rC89cb9a6f74b2: Fix T69044: OpenCL fail due to bad fract function.Aug 22 2019, 5:21 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

svm/

svm_math_util.h

2 lines

util/

util_math_float3.h

6 lines

Diff 17362

View Options

intern/cycles/kernel/svm/svm_math_util.h