Point to Target' from the header menu
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 22 2019, 2:55 PM.

Details

Reviewers

William Reynish (billreynish)
Campbell Barton (campbellbarton)
Bastien Montagne (mont29)

Maniphest Tasks

T69019: Vertex Normal Tools not working/buggy

Commits

rBeae9b8629787: Fix crash using 'Mesh > Normals > Point to Target' from the header menu

Summary

This was working from Alt+N menu but was passing wrong ARegion
(alongside wrong mouse coords) to ED_view3d_win_to_3d_int when called
from the header menu.

Operator context INVOKE_REGION_WIN takes care of this.

part of T69019

Diff Detail

Repository

rB Blender

Branch

T69019_ (branched from master)

Build Status

Buildable 4546
Build 4546: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Aug 22 2019, 2:55 PM

Harbormaster completed remote builds in B4546: Diff 17366.Aug 22 2019, 2:55 PM

William Reynish (billreynish) accepted this revision.Aug 22 2019, 2:56 PM

This revision is now accepted and ready to land.Aug 22 2019, 2:56 PM

Bastien Montagne (mont29) accepted this revision.Aug 22 2019, 3:28 PM

Closed by commit rBeae9b8629787: Fix crash using 'Mesh > Normals > Point to Target' from the header menu (authored by Philipp Oeser (lichtwerk)). · Explain WhyAug 22 2019, 4:04 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBeae9b8629787: Fix crash using 'Mesh > Normals > Point to Target' from the header menu.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_view3d.py

2 lines

Diff 17366

View Options

release/scripts/startup/bl_ui/space_view3d.py

Fix crash using 'Mesh > Normals > Point to Target' from the header menuClosedPublicActions