I don't see why you break the whole logic here, that new version of the check will also be slightly more expansive since you fetch the other poly without first checking the first poly...

Just change the stupid comparison mistake (return (mp_other->flag & ME_SMOOTH) != 0; to return (mp_other->flag & ME_SMOOTH) == 0;) and you are done here. :)

This revision now requires changes to proceed.Aug 23 2019, 11:33 AM

Revert "Fix T68807: smoothing group issue"
just correct comparison mistake

Harbormaster completed remote builds in B4561: Diff 17433.Aug 23 2019, 12:06 PM

In D5561#127194, @Bastien Montagne (mont29) wrote:

I don't see why you break the whole logic here, that new version of the check will also be slightly more expansive since you fetch the other poly without first checking the first poly...

Just change the stupid comparison mistake (return (mp_other->flag & ME_SMOOTH) != 0; to return (mp_other->flag & ME_SMOOTH) == 0;) and you are done here. :)

Not sure what I was thinking there tbh. [ was late yesterday ;) ]

Bastien Montagne (mont29) accepted this revision.Aug 23 2019, 4:19 PM

This revision is now accepted and ready to land.Aug 23 2019, 4:19 PM

Closed by commit rBae0b855a32dd: Fix T68807: smoothing group issue (authored by Philipp Oeser (lichtwerk)). · Explain WhyAug 24 2019, 8:55 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBae0b855a32dd: Fix T68807: smoothing group issue.