Details

Reviewers

Brecht Van Lommel (brecht)
Jacques Lucke (JacquesLucke)

Commits

rCf10affb90721: Shading: Extend Musgrave node to other dimensions
rBf2176b3ff3c5: Shading: Extend Musgrave node to other dimensions.

Summary

This patch extends Musgrave noise to operate in 1D, 2D, 3D, and 4D
space. The Color output was also removed because it was identical
to the Fac output.

This patch was created from the noise-node branch, and it depends on D5560.

Diff Detail

Repository

rB Blender

Branch

musgrave-node (branched from master)

Build Status

Buildable 4768
Build 4768: arc lint + arc unit

Event Timeline

Omar Emara (OmarSquircleArt) created this revision.Aug 23 2019, 9:54 AM

Harbormaster completed remote builds in B4559: Diff 17429.Aug 23 2019, 9:54 AM

Omar Emara (OmarSquircleArt) edited the summary of this revision. (Show Details)Aug 23 2019, 10:15 AM

Omar Emara (OmarSquircleArt) added a parent revision: D5560: Shading: Extend Noise node to other dimensions..

Omar Emara (OmarSquircleArt) mentioned this in T68823: GSoC 2019 - Cycles/EEVEE Improvements.Aug 23 2019, 10:19 AM

Update versioning code.

Harbormaster completed remote builds in B4592: Diff 17506.Aug 25 2019, 11:33 PM

Omar Emara (OmarSquircleArt) edited the summary of this revision. (Show Details)Aug 25 2019, 11:34 PM

This patch was supposed to depend on D5560, but apparently the commits from D5560 are now in this patch as well. So, I am not entirely sure what to do now.

Omar Emara (OmarSquircleArt) planned changes to this revision.Sep 4 2019, 7:10 PM

Merge master and update patch.

Harbormaster completed remote builds in B4768: Diff 17829.Sep 4 2019, 8:34 PM

The musgrave code needs to refactored to avoid writing to inputs and to follow best practices, in particular, we want the declarations to be closer to the initializations and limit the scope of variables.