Details

Reviewers

Summary

Various Synced Selection Fixes

These changes are mostly less noticable cases where a selection sync is needed. I did not take the time to fix or test all of these cases earlier because I first wanted the selection syncing algorithm to be reviewed and accepted before proceeding.

Ensure that syncs occur on changing, creating, and deleting view layers.
Tag for syncing after changing scenes. With unique scenes, syncing already functioned as expected. When a linked copy of a scene is created, the outliner tree element selection state is maintained between the two scenes, so it is required to sync on scene changes because a scene may be a linked copy.
Tag for syncing after creating a full copy of a scene.
Sync selection on creating a new workspace
Sync selection on loading a file/homefile with load UI disabled
Sync selection on duplicating objects
Sync selection on separate operators
Sync selection on paste in 3D view, sequencer, and outliner.
Sync selection on various outliner operations (object ops, drag and drop)
Sync selection when selecting/deselecting collection contents from outliner

Diff Detail

Repository

rB Blender

Branch

outliner-syncing-fixes (branched from master)

Build Status

Buildable 7504
Build 7504: arc lint + arc unit

Event Timeline

Nathan Craddock (natecraddock) created this revision.Aug 23 2019, 11:15 PM

Harbormaster completed remote builds in B4578: Diff 17465.Aug 23 2019, 11:15 PM

Nathan Craddock (natecraddock) retitled this revision from These changes are mostly less obvious cases where a selection sync is needed. I did not take the time to fix or test all of these cases earlier because I first wanted the selection syncing algorithm to be reviewed and accepted before proceeding. to Outliner synced selection refinements.Aug 23 2019, 11:15 PM

Nathan Craddock (natecraddock) edited the summary of this revision. (Show Details)

Nathan Craddock (natecraddock) added a reviewer: Campbell Barton (campbellbarton).

William Reynish (billreynish) awarded a token.Aug 24 2019, 12:18 AM

noki paike (amonpaike) awarded a token.Aug 24 2019, 9:23 PM

Updated with more syncing fixes for separation, duplication, and outliner operations

Harbormaster completed remote builds in B4584: Diff 17486.Aug 25 2019, 4:55 AM

Nathan Craddock (natecraddock) edited the summary of this revision. (Show Details)Aug 25 2019, 4:57 AM

Outliner: fix select sync on sequence paste

Harbormaster completed remote builds in B4585: Diff 17487.Aug 25 2019, 5:00 AM

Nathan Craddock (natecraddock) edited the summary of this revision. (Show Details)Aug 25 2019, 5:00 AM

Sync w/ master

Harbormaster completed remote builds in B4614: Diff 17555.Aug 27 2019, 7:48 AM

Before adding calls anywhere objects are added/removed. I'd like to look into handling this in a generic way.
There are so many places where object selection changes that remembering to call update functions all over the code is error prone.
For objects we already have two update calls that handle this:

DEG_id_tag_update(&scene->id, ID_RECALC_SELECT);
WM_event_add_notifier(C, NC_SCENE | ND_OB_SELECT, scene);

The ID_RECALC_SELECT flag could be made to set the dirty flag.

Or we could have a single function call when selection changes which calls DEG_id_tag_update, WM_event_add_notifier & ED_outliner_select_sync_from_object_tag.

This is more a design task at the moment, I'd like to put this path on hold until we agree on how sync selection should be handled.

source/blender/editors/screen/workspace_edit.c
360 ↗	(On Diff #17555)	This should be called from `WM_window_set_active_workspace`.
source/blender/makesrna/intern/rna_wm.c
846 ↗	(On Diff #17555)	This is called from other places, suggest `WM_window_set_active_view_layer` tags for sync selection instead of just doing it from RNA.

Added T69212: Outliner Sync Selection: Use general update method - design task for sync select generalization.

For now I'd like to avoid adding sync selection calls for individual operators which are already tagging the depsgraph for selection updates.

Global selection syncing tags on file load will be needed irrespective, so these are fine to go in.

source/blender/windowmanager/intern/wm_files.c
1975–1977 ↗	(On Diff #17555)	This can go into master.
2234–2236 ↗	(On Diff #17555)	This can go into master.

Move scene, viewlayer, and workspace update tagging out of RNA

Harbormaster completed remote builds in B4661: Diff 17651.Aug 29 2019, 5:34 AM

I moved the tagging on setting view layer, scene, and workspace from the RNA. I think it would be safe now to commit this, the improvements to syncing, and tagging for outliner operations.

Merge branch 'master' into arcpatch-D5572
Merge branch 'master' into arcpatch-D5572

Harbormaster completed remote builds in B4701: Diff 17720.Aug 31 2019, 5:17 AM

Nathan Craddock (natecraddock) edited the summary of this revision. (Show Details)Aug 31 2019, 5:18 AM

Philipp Oeser (lichtwerk) mentioned this in T71404: 2.81 Outliner: selection not synced when editing armature.Nov 7 2019, 1:44 PM

Nathan Craddock (natecraddock) mentioned this in T71257: Unify outliner "select hierarchy" behavior with shift-selection behavior.Nov 25 2019, 7:38 PM

Merge with master

Harbormaster completed remote builds in B7503: Diff 23551.Apr 8 2020, 5:36 AM

Nathan Craddock (natecraddock) edited the summary of this revision. (Show Details)Apr 8 2020, 6:02 AM

Sync on collection select and deselect

Harbormaster completed remote builds in B7504: Diff 23553.Apr 8 2020, 6:07 AM

@Campbell Barton (campbellbarton) Before adding calls anywhere objects are added/removed. I'd like to look into handling this in a generic way.

I am looking through the remaining outliner operators to see if any others need sync fixes. I'm working on D5864 again to address the generic update function, but I think it would be best to just commit this once I finish checking outliner operators rather than waiting. Do you still think otherwise?

Julian Eisel (Severin) mentioned this in T75610: Outliner select hierarchy parent and children drag'n'drop into another collection works incorrectly.Apr 20 2020, 12:59 AM

Julian Eisel (Severin) mentioned this in rBd290bdd42abb: Fix missing Outliner selection syncing on "Select Hierarchy".Apr 20 2020, 1:07 AM

Nathan Craddock (natecraddock) abandoned this revision.Nov 7 2020, 5:26 PM

Outliner synced selection refinements
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 23553

source/blender/editors/curve/editcurve.c

source/blender/editors/gpencil/gpencil_edit.c

source/blender/editors/mesh/editmesh_tools.c

source/blender/editors/object/object_add.c

source/blender/editors/render/render_shading.c

source/blender/editors/scene/scene_edit.c

source/blender/editors/space_outliner/outliner_collections.c

source/blender/editors/space_outliner/outliner_dragdrop.c

source/blender/editors/space_outliner/outliner_edit.c

source/blender/editors/space_outliner/outliner_tools.c

source/blender/editors/space_sequencer/sequencer_edit.c

source/blender/editors/space_view3d/view3d_ops.c

source/blender/windowmanager/intern/wm_window.c

Outliner synced selection refinementsAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23553

source/blender/editors/curve/editcurve.c

source/blender/editors/gpencil/gpencil_edit.c

source/blender/editors/mesh/editmesh_tools.c

source/blender/editors/object/object_add.c

source/blender/editors/render/render_shading.c

source/blender/editors/scene/scene_edit.c

source/blender/editors/space_outliner/outliner_collections.c

source/blender/editors/space_outliner/outliner_dragdrop.c

source/blender/editors/space_outliner/outliner_edit.c

source/blender/editors/space_outliner/outliner_tools.c

source/blender/editors/space_sequencer/sequencer_edit.c

source/blender/editors/space_view3d/view3d_ops.c

source/blender/windowmanager/intern/wm_window.c

Outliner synced selection refinements
AbandonedPublic
Actions

Revision Contents
Changeset List