Poly build tool improvements
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Aug 24 2019, 1:15 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
William Reynish (billreynish)

Commits

rBd8baafd693eb: Edit Mesh: Poly build tool improvements

Summary

Poly build tool improvements

This patch implements some improvements to make the poly build tool more suitable for retopology tasks.

Smarter edge/face/vert preselection
Geometry preview
Automatic quad creation
Create/move/delete mesh elements from the same tool, using a similar and consistent interaction

Even if the tool makes the retopology experience much better, there are still some blocking issues that prevent us to have a decent retopology experience.

You have to configure snapping and auto merge editing manually each time you want to use this tool.
There isn't a viewport mode available that works with this tool. We need to implement a new mesh display mode specific to retopology. See T67997
Preselection does not take element visibility into account. To achieve this, we will probably need to define a target retopology mesh when using the tool. This needs to match with the new mesh display mode to return only visible mesh element. This issue makes impossible to retopologize an entire model using this tool.

To Do:

Refactor the gizmo
There is a conflict in the keymap (with enable snapping) if we use Ctrl + drag to create geometry

Diff Detail

Repository

rB Blender

Branch

polybuild-1 (branched from master)

Build Status

Buildable 4605
Build 4605: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Aug 24 2019, 1:15 AM

Harbormaster completed remote builds in B4579: Diff 17469.Aug 24 2019, 1:15 AM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Aug 24 2019, 1:19 AM

Pablo Dobarro (pablodp606) added reviewers: Campbell Barton (campbellbarton), William Reynish (billreynish).

Ryan (RyanJEC) awarded a token.Aug 24 2019, 4:51 AM

Johannes Kollmer (Lumpengnom) awarded a token.Aug 24 2019, 8:59 AM

Alexander Dumproff (A.Lex_3D) awarded a token.Aug 24 2019, 11:43 AM

Alexander Dumproff (A.Lex_3D) added a subscriber: Alexander Dumproff (A.Lex_3D).

Jun Mizutani (jmztn) awarded a token.Aug 24 2019, 5:24 PM

Jun Mizutani (jmztn) added a subscriber: Jun Mizutani (jmztn).

babajan (johnsyed) awarded a token.Aug 24 2019, 7:56 PM

babajan (johnsyed) added a subscriber: babajan (johnsyed).

noki paike (amonpaike) awarded a token.Aug 24 2019, 8:56 PM

xrg (xrg) awarded a token.Aug 24 2019, 9:12 PM

M (justastatue) awarded a token.Aug 25 2019, 7:07 AM

Daniel Santana (dgsantana) awarded a token.Aug 25 2019, 8:12 PM

Tested, previews are nice but noticed some issues.

On first activation it behaves as if Ctrl is held (shows a triangle extended from the edge), tapping Ctrl resolves.
I can get both the add & remove (red and blue) previews to show at once (hold shift and move the cursor around the model).
There are quite a few unused variables & arguments which should be marked as UNUSED or removed.

Otherwise this seems fine.

source/blender/editors/space_view3d/view3d_gizmo_preselect_type.c
145–149	No need to shout :)
158	called `mval_fl` elsewhere, no need to define zero then assign. can be written as: `const float mval_fl[2] = {UNPACK2(mval)};`

This revision now requires changes to proceed.Aug 26 2019, 1:46 PM

Update for review

I fixed some bugs and warnings. Now the gizmo should update correctly with the keymap hack
I also added another operator macro to extrude quads directly by clicking and dragging.

Harbormaster completed remote builds in B4605: Diff 17543.Aug 26 2019, 11:56 PM

Extrude edges by clicking and dragging

Now the tool extrudes quads by clicking and dragging on boundary edges. Triangle/Quad creation tool is available when pressing Ctrl and delete when pressing shift.
It also prioritizes internal vertices when tweaking geometry.

Harbormaster completed remote builds in B4609: Diff 17549.Aug 27 2019, 2:45 AM

Minor changes suggested inline, otherwise LGTM.

source/blender/editors/include/ED_mesh.h
246	Convention is to start these with `e`, could also include `EditMesh` in name. eg: `eEditMesh_PreSelPreview`
source/blender/editors/mesh/editmesh_preselect_elem.c
263–264	Think this would read better written as: psel->preview_tris = MEM_mallocN(sizeof(psel->preview_tris) 2, __func__); psel->preview_lines = MEM_mallocN(sizeof(psel->preview_lines) 4, __func__);
source/blender/editors/mesh/editmesh_select.c
1411	`use_boundary_edges \|\| use_boundary_edges` ? To catch these with `gcc` add the CFLAG `-Werror=logical-op`