Details

Reviewers

Bastien Montagne (mont29)
Philipp Oeser (lichtwerk)

Commits

rBAa215a3c85ad9: Principled Node added in Add Images as Planes

Summary

This is about replacing the Diffuse shader with a principled shader, so that exporting to other formats like OBJ, FBX, GLTF becomes hassle - free as the textures are also imported along with it , as mentioned in the Task T66299

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Himanshi Kalra (calra) created this revision.Aug 27 2019, 8:10 PM

Using the original file name and path

Some changes needed here, but i can do the cleanup and commit on yuour behalf too if you want, might be quicker?

io_import_images_as_planes.py
22–26	No reason to change those, just increase the version number
344–347	No changes in empty lines, spacing and other such cleanup in patches please. Only relevant stuff.
736	just replace 'Diffuse' by 'Principled' instead, there is no point in adding new stuff while changing behavior of existing option to mimic new option behavior

Hi thanks for reviewing, I wanted to do it as it would be my first commit, but if I get stuck you can do it as well .... I will clean up the code and update it . I had this one doubt the new version would be called (3,2,3) right ? Thanks

Incremented the version number and corrected some changes, and cleansed the patch.

Almost ready for commit :)

io_import_images_as_planes.py
24	You can increase the middle number here, this is a important change in the add-on, not a simple minor fix. So `3, 3, 0` ;)
345	Tsst, changes in indentation ;)
395–397	Tsst, changes in indentation ;)
1014–1018	No need to keep those comments :)
1031	No need to keep those comments :)
1034–1040	No need to keep those comments :)